-
Notifications
You must be signed in to change notification settings - Fork 108
[French Translation] Part 2 of n (n is unknown 🤣) #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Stop review at ligne 135 / <!-- Change record -->
<!-- Change record type -->
Stop at line 306 <!-- Settings -->
Just review not going ahead ...
|
Note for myself |
|
Cont from #417 (comment)
|
|
Hi, Regarding your answer: "3. Should be possible to build apk from github actions here https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml by clicking on "run workflow". It may not build because there are some apostrophes in this PR that need to be escaped with slash." 3.1 Using escape character should be handled (automatically) in an other way ... translator shouldn't be annoyed by this kind of "technical constraint"😕. What do you think? |
|
Regarding answer "4. Depends on what do you want to do with vacations data later? The easiest way would be to create an activity " Vacation" and track it." |
Would be cool, unfortunately I don't know if Android development tools has this kind of automation.
It hasn't been run for a long time, and got broken, and was failing. Should be working now in dev branch. After the successful run, there will be an artifact available for download.
There is a duration format option, but it is global for all activities unfortunately. |
|
Also can I mention you in the app as a translator and what name should be used for this? |
No mention yet before I have performed a full review of the app translation and before I become, hopefully, a daily user of the app🤞. |
Current Status:
|
'balise' replaced by 'étiquette' ... brut (but yet manual 😉) search and replace.
Updated French strings for better clarity and consistency.
Sorry for the confusion, it should be run from your repo.
Unfortunately I don't have access to the computer at the moment, so can't verify that is the build error. But looking at the changes, there are a lot of unescaped apostrophes. Also line 49 should probably have %s similar to next lines.
This is a debug message and it can be ignored by clicking Ok. |
|
Many thanks for your answers 👍. Build ran with success on my repo ✅. |
|
Hi, I commited my changes on my "dev" branch. Resources
|
|
Full logs are visible only to the owner, so can't access them unfortunately. Can you paste part of the log with the error here or attach a screen? Looking at line 406 at dev branch, doesn't see any thing suspicious. Also please make sure that you are selecting correct branch for the build, because ldmpub-fr-review-2 branch still contains unescaped apostrophes. Also changes to your dev branch are not visible in this PR, because it is opened for the ldmpub-fr-review-2 branch. In order to merge all changes into original repo, it would be needed either to apply all required changes to the ldmpub-fr-review-2 branch (preferred way), or open another PR from your dev branch to original dev branch. |
I will try to give you the rights ...
Yes, everything is clear about branches + build process for me and ... the building job is working again🥳.
I will handle this point later. |
|
I have added your user to my repo, can you please (if your current rights are OK):
Question about the workflow process:
(1) a test job is automatically triggered after each commit and they are 7+ minutes looong |
|
Last subject for today: can you improve logs for the subtask "Build" on "Build" job? Note: performing translation using Weblate can greatly help us 😉 |
Failing "test" jobs can be ignored, they don't affect anything.
Build job can be run at anytime.
Unfortunately it is handled by outside plugins.
Weblate support is on the roadmap. |
|
Thanks 👍. To let you know:
I will (manually) copy all changes here from the ldmpub-review-2 branch when ready ... The use of the app reveals few bug but there is room for improvement ... in particular around UI ... I will open separated issues. |
|
Hi, Suggestion to improve english translation (because "a double negation sentence" is always hard to understand) for key name="settings_untracked_range_hint" Actual Suggested |
|
Sounds good. How about this one? Show untracked time only within the selected range. "Consider" is a bit ambiguous it seems. I'll change it on the main branch and translate other languages through chatgpt. |
|
Perfect 👍. |
|
Hi, Please find my final proposal tested in the app itself (thanks to the easy "build workflow" 👍) It may not be perfect but far much better. Ready to discuss these changes (remarks may lead to add new translation strings, change of source / english string and even UI rework 😉). |
Razeeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Left few comments to discuss.
| • La catégorie <custom-color-3>Loisirs sportifs</custom-color-3> peut regrouper les activités <custom-color-3>Course à pied</custom-color-3> et <custom-color-3>Golf</custom-color-3>.<br><br> | ||
| • La catégorie <custom-color-1>Détente</custom-color-1> peut regrouper les activités <custom-color-1>Télévision</custom-color-1> et <custom-color-1>Lecture</custom-color-1>.<br><br> | ||
| Cela vous permet de mesurer le temps que vous passez globalement sur toutes vos activités Sportives ou de Détente.<br><br> | ||
| Les <b>Étiquettes</b> permettent d\'ajouter plus de détails sur un enregisgrement. Par exemple :<br><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enregisgrement -> enregistrement?
| • La catégorie <custom-color-1>Détente</custom-color-1> peut regrouper les activités <custom-color-1>Télévision</custom-color-1> et <custom-color-1>Lecture</custom-color-1>.<br><br> | ||
| Cela vous permet de mesurer le temps que vous passez globalement sur toutes vos activités Sportives ou de Détente.<br><br> | ||
| Les <b>Étiquettes</b> permettent d\'ajouter plus de détails sur un enregisgrement. Par exemple :<br><br> | ||
| • Pour un enregistrment de l\'activité <custom-color-3>Lecture</custom-color-3>, ajoutez une ou plusieurs étiquettes comme <custom-color-3>Arsène Lupin</custom-color-3> ou <custom-color-3>Harry Potter</custom-color-3> afin de suivre le temps passé sur chaque livre.<br><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enregistrment -> enregistrement?
|
|
||
| <!-- Activity filters --> | ||
| <string name="change_activity_filters_hint">Filtres d\'activité</string> | ||
| <string name="change_activity_filters_hint">Filtrer les activité</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was more like "filters of activities" (noun), now it's more like "to filter activities" (verb). Keep original maybe?
| <string name="record_types_empty">Aucune activité</string> | ||
| <string name="record_tag_selection_hint">Sélectionnez une étiquette pour l\'enregistrement</string> | ||
| <string name="time_now">Maintenant</string> | ||
| <string name="cannot_be_in_the_future">Impossible de prédire le futur ^_^</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emojies in texts are inconsistent with the rest of the UI. How about "L’heure ne peut pas être dans le futur"?
| <string name="settings_keep_statistics_range">Mémoriser la période de statistiques</string> | ||
| <string name="settings_keep_statistics_range_hint">Si activé, les statistiques détaillées seront ouvertes pour la même période que celle sélectionnée dans les statistiques.</string> | ||
| <string name="settings_retroactive_tracking_mode">Activer les enregistrements à postériori</string> | ||
| <string name="settings_retroactive_tracking_mode_hint">L\'activité sélectionnée se termine au lieu de démarrer.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems oversimplified and potentionally misleading. Maybe keep original?
| <string name="notification_record_type_stop">Arrêt</string> | ||
| <string name="notification_goal_time_description">Objectif atteint</string> | ||
| <string name="notification_limit_time_description">Limite atteinte</string> | ||
| <string name="notification_time_started">Début</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a template "%s" there an actual time would be inserted.
| <string name="change_record_tag_select_activity_hint">Utiliser la couleur et l\'icône d\'une activité</string> | ||
| <string name="change_record_tag_default_types_hint">L\'étiquette serait attribuée par défaut lors du démarrage d\'un enregistrement pour les activités sélectionnées</string> | ||
| <string name="change_record_type_value_type_field">Information complémentaire</string> | ||
| <string name="change_record_type_value_type_hint">Renseignez une information lorsque cette étiquette est attribuée à un enregistrement. Utile pour suivre le nombre de pas ou de pages lues, l\'humeur (via un émoticon), etc.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tag values are numbers so emoticons can't be entered.
| <br/> | ||
| \"Reading\",2023-05-30 14:45:21,2023-05-30 15:45:21,\"Comment, comment\" | ||
| Exemple :<br/> | ||
| \"Lecture\",2026-12-31 09:45:00,2026-12-31 10:55:35,\"Commentaire, blabla\" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"blabla" is a bit inconsistent with the overall tone.
| <string name="running_records_empty_hint_inverted">Cliquez pour éditer</string> | ||
| <string name="running_records_add_type">Ajouter</string> | ||
| <string name="running_records_types_empty">Bienvenue. Pour commencer, ajoutez les activités que vous souhaitez enregistrer. Appuyez sur le bouton \'%s\' pour créer une activité personnalisée ou sur \'%s\' pour créer une activité à partir d\'un modèle.</string> | ||
| <string name="running_records_empty">Appuyez sur une activité pour démarrer l\'enregistrement</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was "long click to edit", now its "click to start recording" which has different meaning?
| <string name="running_records_add_type">Ajouter</string> | ||
| <string name="running_records_types_empty">Bienvenue. Pour commencer, ajoutez les activités que vous souhaitez enregistrer. Appuyez sur le bouton \'%s\' pour créer une activité personnalisée ou sur \'%s\' pour créer une activité à partir d\'un modèle.</string> | ||
| <string name="running_records_empty">Appuyez sur une activité pour démarrer l\'enregistrement</string> | ||
| <string name="running_records_empty_inverted">Appuyez longuement sur une activité pour démarrer l\'enregistrement</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed meaning from "click to edit" to "long click to start recording"?
I made changes on dev branch ... now I copy them here ...
|
Full review done: changes or comments. It's very hard for me to navigate between comment while seeing the english XML, the old "french" one and the new one (my suggestions). Any advice to easy my work? |
Correct '
demmaré => démarré

Stop at line 306
<!-- Settings -->For reference: first PR was #417