fix: resolve format-check CI failures (biome format + import order) - #188
Open
Trosper3 wants to merge 2 commits into
Open
fix: resolve format-check CI failures (biome format + import order)#188Trosper3 wants to merge 2 commits into
Trosper3 wants to merge 2 commits into
Conversation
Run `npm run format` (biome check --write .) to fix 58 formatting and 33 import-order violations across ~30 files, and `biome migrate` to bring biome.json up to the installed 2.5.8 schema. Mechanical only: quote/semicolon/indent normalization, import reordering, and 4->2 space reindent in Data.json. No logic changes; lint results unchanged (65 problems, pre-existing) and build succeeds. Closes #181 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K5wXdN2yC9f8vuAuXBVCNo
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Redux Build System — CI Report
Overall: ❌ 3 passed · 2 failed · 3 skipped ❌ audit — 1 high
❌ lint — 24 errors, 41 warnings
|
Tools/ProblemInstanceParser.js:72 had `([\w!]+)+` — a `+`-quantified group whose body is itself `+`-quantified. The outer `+` is redundant (the character class already matches one-or-more) and creates exponential backtracking on inputs like many repeated `!` characters, flagged by CodeQL (js/redos). Dropping the outer `+` is behaviorally identical (verified against valid/invalid sample inputs) and resolves instantly on the adversarial input that hung the original. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K5wXdN2yC9f8vuAuXBVCNo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run format(biome check --write .) to fix the 58 formatting and 33 import-order violations flagged by theformat-checkCI job (quote style, semicolons, indentation, import ordering/merging).biome migrateto bringbiome.json's$schemaup to the installed Biome 2.5.8 (was pinned at 2.5.3).Test plan
npm run format:checkpasses cleanly (was 117 errors, now 0)npm run lintproduces the same 65 problems (24 errors, 41 warnings) before and after — confirmed via stash/pop comparison, so no lint regressionsnpm run buildsucceedsData.json,StandardSATSvgReact.js) — purely mechanical reformatting/import reordering, no logic changesCloses #181
🤖 Generated with Claude Code