Fix hash_test.go to compile with updated NewParser signature#268
Merged
Conversation
NewParser gained an `input string` parameter, but sdks/go/src/hash_test.go was never updated, so `go test ./src/...` failed to compile. The test only exercises relationIdFromString, which does not read input, so pass "". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
comnik
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sdks/go/src/hash_test.gocalledNewParser([]Token{})with a single argument, butNewParser(insdks/go/src/parser.go) now has the signaturefunc NewParser(tokens []Token, input string) *Parser. This one-line fix passes the missinginputargument.Why
The test was never updated when
NewParsergained itsinputparameter, socd sdks/go && go test ./src/...has failed to compile since before v0.5.5. The canonical suite (go test ./test/...) andgo build ./...were unaffected, which is why it went unnoticed.Notes for reviewers
TestRelationIdFromStringonly exercisesrelationIdFromString, which never readsinput/lineStarts, so""is the correct argument. Verified withcd sdks/go && go test ./src/...— passes.🤖 Generated with Claude Code