service repsponse addition#15
Open
sarthakdas wants to merge 4 commits intomainfrom
Open
Conversation
cmower
requested changes
Sep 11, 2025
Contributor
cmower
left a comment
cmower
left a comment
There was a problem hiding this comment.
you committed build files, please remove
| node_info_t nodes[n_nodes]; // Array to hold nodes | ||
| } | ||
|
|
||
| struct service_response_t { |
Contributor
There was a problem hiding this comment.
bad name choice, better something like status_t
Comment on lines
61
to
63
| int64_t success; | ||
| string message; | ||
| } No newline at end of file |
cmower
requested changes
Sep 11, 2025
Comment on lines
+60
to
+62
| struct status_t { | ||
| // success returns True/False if its successful or not | ||
| // message returns the error message, or the success message |
Contributor
There was a problem hiding this comment.
weird, choose either following options
var; // doc...
var; // doc...
or
// doc
var;
// doc
var;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.