Feat/jazzy/simulator compatibility#98
Open
jlgalanRB wants to merge 6 commits into
Open
Conversation
Contributor
Author
jlgalanRB
marked this pull request as ready for review
July 7, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the Gazebo simulation-related pieces in
robotnik_descriptionto keep this repository focused on the robot description itself.The main goal is to decouple the robot URDF/Xacro description from simulator-specific control configuration, moving the responsibility for composing the final Gazebo simulation model to the simulation layer.
Motivation
Until now, several robot descriptions in
robotnik_descriptiondirectly included Gazebo-specific control macros and controller parameter references. This created a tight coupling between:ros2_controlconfiguration filesThat coupling made the description package less reusable and pushed simulation concerns into a repository whose responsibility should be the robot model definition.
With this change,
robotnik_descriptionprovides the physical robot description and the Gazebo adapter macros, but the final composition of the simulated robot and its controller configuration is expected to be handled fromrobotnik_simulation.What changes
1. Remove embedded Gazebo control composition from robot/base descriptions
Several robot/base xacros no longer instantiate Gazebo control macros internally when
gazebo_ignitionis enabled.This means robot description files stop directly adding
gz_ros2_controlas part of the base/body definition.2. Generalize Gazebo control adapter macros
The Gazebo control xacros under
simulators/gazebo_ignition/...are updated so they can be composed externally through a common interface.In particular, they now receive the controller config file as an argument instead of resolving it internally from
robotnik_description.3. Add a generic Gazebo composition xacro
A new wrapper xacro is introduced:
simulators/gazebo_ignition/robot.urdf.xacroThis file composes:
This provides a clean entry point for simulation packages that need the full Gazebo-ready robot description.
4. Remove controller YAML ownership from this repository
Controller parameter YAML files previously stored under
robotnik_description/simulators/gazebo_ignition/...are removed.These configs are intended to live in the simulation layer, where they belong conceptually.
5. Documentation updates
Documentation is updated to reflect that simulator control is no longer part of the robot description itself and must be composed externally.
Intended architecture after this PR
After this change:
robotnik_descriptionowns robot geometry, links, joints, sensors, and reusable Gazebo adapter macrosrobotnik_simulationowns simulator launch logic and controller configurationImpact
This change is mainly architectural, but it is important because it:
Notes
This PR is intended to be used together with the corresponding changes in
robotnik_simulation, where:ros2_controlYAMLs are relocated