feat(attention): optional 'mark seen on click' for waiting notifications#60
Merged
Merged
Conversation
Adds a new setting `attentionClickClearsWaiting` (default off, preserves historical behavior) plus an inline mode pill in the attention bell dropdown header. When enabled, clicking a row for a waitingForApproval / waitingForInput session both navigates to the tab and dismisses the notification, matching Slack/Gmail-style 'click marks seen' UX. The attentionService.dismiss() flow already re-surfaces events on the next status transition or via the idle-too-long escalation, so the bell will keep nagging if the session genuinely still needs attention. Closes #59 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59.
Problem
Clicking a row in the attention bell for a session in
waitingForApproval/waitingForInputstate correctly navigates to the tab, but the event stays in the bell and keeps counting toward the unread badge. Onlyfinishedevents are cleared on click. Reporter argued for Slack/Gmail-style "click = mark seen" UX.The current behavior is intentional (the dedicated X button on each row is the explicit dismiss path; a row click is "passive — let me look"), but the alternative is reasonable. So this PR makes both available as a user choice.
Changes
attentionClickClearsWaiting(defaultfalse, preserves historical behavior).--dplex-accentso it's readable on both light and dark themes.rowClickAction.ts) for testability.finishedstill always acknowledges on click — independent of the setting. The existingdismiss()flow handles re-surfacing: events come back on the next status transition or viasweepIdle()escalation.Verification
npm run typecheckpassesnpm run test:unit— 328/328 passing, including 3 new testscolor: 'white'invisible on light themes — fixedpackage-lock.jsonversion — fixed