fix: filter out empty text blocks from user messages for Gemini compatibility #10728
+102
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tibility
Gemini models via OpenRouter require non-empty content in the 'parts' field.
When user messages contain empty text blocks ({ type: 'text', text: '' }),
the API rejects the request with 'must include at least one parts field'.
This fix filters out empty text blocks when converting Anthropic messages
to OpenAI format, ensuring only valid content is sent to the API.
- Filter empty text blocks from user messages before creating OpenAI format
- Preserve images (they always have base64 content)
- Skip user message creation if all content blocks are empty
- Add 3 test cases for the new filtering behavior
Fixes: https://us.posthog.com/error_tracking/019bbc67-ebdc-7640-967c-df1c8f43172b
dosubot
bot
added
size:L
Contributor
Review complete. No issues found. The implementation correctly filters empty text blocks from user messages to prevent Gemini's "must include at least one parts field" error. The fix is well-scoped, properly tested, and does not break existing functionality. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for the "Unable to submit request because it must include at least one parts field" error that occurs when using Gemini models via OpenRouter.
Root Cause
User messages containing empty text blocks (
{ type: "text", text: "" }) were being passed through to the API without filtering. Gemini requires non-empty content in the 'parts' field.Solution
Added filtering of empty text blocks in
convertToOpenAiMessages()when processing user messages:{ type: "text", text: "" }) are filtered outChanges
src/api/transform/openai-format.ts- Added filtering logicsrc/api/transform/__tests__/openai-format.spec.ts- Added 3 test casesTesting
PostHog Issue
https://us.posthog.com/error_tracking/019bbc67-ebdc-7640-967c-df1c8f43172b
Linear Issue
ROO-528
Important
Filters out empty text blocks in
convertToOpenAiMessages()to prevent errors with Gemini models, with new tests added.convertToOpenAiMessages()inopenai-format.tsto prevent errors with Gemini models.openai-format.spec.tsto verify filtering logic.This description was created by
for 4928810. You can customize this summary. It will automatically update as commits are pushed.