feat: wasm duplex streams - #1337
Merged
Merged
Conversation
Also fixes CpalProcessor refreshing its Wasm memory view before calling into Rust rather than after, which left the view detached for a quantum whenever process() grew the heap.
They no longer just beep, so name them after the host each one exercises. The duplex mode sits next to the existing two-stream loopback so the two can be compared by ear.
Member
Author
|
I verified this works well myself with the examples, so I'm going to merge when the CI passes. Feel free to raise issues or PRs for any further improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplex support for Web Audio and AudioWorklet 🎉
As I as working on this, I clarified some of the docs and added a
DeviceTrait::default_duplex_configwith a default implementation that tries to match input and output on a shared channel count and sample rate wherever possible, preferring whateverdefault_input_config/default_output_configwould already pick.