Adds a builder for configuring outputstreams #815
Conversation
Its basically the same as the microphone builder. It will replace the OutputStream. In the future we'll add more abstractions on top. Until its done it lives under an experimental flag. Names are subject to change too, Speakers is probably not ideal but it conveys the meaning better then OutputStream. I'm thinking of having a Source -> Stream -> Sink terminolgy where a Sink could be the audio card, the network or a file (the wavwriter).
yara-blue
force-pushed
the
output-builder
branch
from
40c2732 to
1e4dbbe
Compare
roderickvd
left a comment
roderickvd
left a comment
There was a problem hiding this comment.
In RustAudio/cpal#956 I was also toying around with the idea of a StreamConfigBuilder - let me know how we can align those efforts!
| /// Adds a new source to the end of the queue. | ||
| #[inline] | ||
| pub fn append<T>(&self, source: T) | ||
| pub fn append<T>(&self, source: T) -> usize |
There was a problem hiding this comment.
What's the rationale for changing this to return a usize? By analogy, Vec::append doesn't return a value either.
There was a problem hiding this comment.
Oh haha, I needed this for some tests in zed. I'll throw it out. Good catch!
| #[derive(Debug, thiserror::Error, Clone)] | ||
| pub enum Error { | ||
| /// No output device is available on the system. | ||
| #[error("There is no input device")] |
| //! | ||
| //! # fn main() -> Result<(), Box<dyn std::error::Error>> { | ||
| //! // List all available input devices | ||
| //! let inputs = available_outputs()?; |
| .supported_output_configs() | ||
| .map_err(|source| Error::OutputConfigs { | ||
| source, | ||
| device_name: device.name().unwrap_or_else(|_| "unknown".to_string()), |
There was a problem hiding this comment.
Device::name has been deprecated in favor of Device::description().name() in cpal v0.17. You could also choose to pretty-print Device::description.
| }, | ||
| ) => { | ||
| let n_samples = n_frames * self.channel_count.get() as u32; | ||
| (*min_samples..*max_samples).contains(&n_samples) |
There was a problem hiding this comment.
For cpal v0.18 I have the idea to have something like a cpal::BufferSize::Range { min, max } that you can request. Open to API ideas: RustAudio/cpal#956
|
As for naming, here are some suggestions:
If we want to use Source → Stream → Sink terminology (pretty accurate actually) then to disambiguate we should rename the existing Sink to something like MixerQueue, AudioQueue, or QueuedOutput. |
Its basically the same as the microphone builder. It will replace the OutputStream. In the future we'll add more abstractions on top. Until its done it lives under an experimental flag.
Names are subject to change too, Speakers is probably not ideal but it conveys the meaning better then OutputStream. I'm thinking of having a Source -> Stream -> Sink terminolgy where a Sink could be the audio card, the network or a file (the wavwriter).