Skip to content

DX fix and legacy js cleanup - #6969

Open
vedanshshetti wants to merge 1 commit into
SAP:mainfrom
vedanshshetti:main
Open

vedanshshetti wants to merge 1 commit into
SAP:mainfrom
vedanshshetti:main

Conversation

@vedanshshetti

Copy link
Copy Markdown

Summary

This PR improves consistency, type safety, and documentation across the logger utilities and Kibana formatter in the SAP Cloud SDK.

Motivation

The SDK follows a strict TypeScript style with explicit return types, consistent JSDoc usage, and modern idiomatic patterns. Several functions were missing return types, one used a legacy has()/get() pattern, and sanitizeRecord used any instead of unknown. This PR aligns these areas with the rest of the codebase.

Changes

  • Added explicit void return types to toggleMuteLoggers and toggleSilenceTransports
  • Added JSDoc to toggleMuteLoggers and kibanaTransformer
  • Replaced redundant has() check in getLogger with direct get() access
  • Replaced any with unknown in sanitizeRecord for improved type safety

Notes

No behavioral changes. All tests pass.

@cla-assistant

cla-assistant Bot commented Sep 13, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vedansh Shetti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vedanshshetti

Copy link
Copy Markdown
Author

Hi, your bot is saying I didnt sign the CLA, even though I did.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant