Adding the two .cfg files for gen_g4_detsim_reco1, and reco2_caf#5
Open
Li-Jiaoyang97 wants to merge 1 commit intomasterfrom
Open
Adding the two .cfg files for gen_g4_detsim_reco1, and reco2_caf#5Li-Jiaoyang97 wants to merge 1 commit intomasterfrom
Li-Jiaoyang97 wants to merge 1 commit intomasterfrom
Conversation
Member
|
I fully approve of us committing some of this! I'm going to hold off on officially approving it until we have MCP2023B up and running over the coming few days. At that point @VCLanNguyen can add a couple of extra commits to this with all the new variants of the cfgs she has been producing for our new workflows 😄 |
|
@henrylay97 @Li-Jiaoyang97 Updates on this? can be closed/merged? |
henrylay97
approved these changes
Feb 12, 2024
Member
henrylay97
left a comment
henrylay97
left a comment
There was a problem hiding this comment.
Sorry Miquel. Yeah no reason not to merge this. I've initiated a slack discussion on the other things that I thought we should commit at the time of MCP2023B but that can form a separate PR if needed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is saving two config files for the workflow: gen_g4_detsim_reco1 -> reco2_caf for the future production purpose.