Open
Conversation
EamonnGlynn
requested review from
Angelyr,
RPIFisherman,
cwsmith and
onkarsahni
as code owners
onkarsahni
requested changes
Jun 4, 2024
| h_strainRate(i,3) = xyShear[i]; | ||
| h_strainRate(i,4) = xzShear[i]; | ||
| h_strainRate(i,5) = yzShear[i]; | ||
| } |
There was a problem hiding this comment.
Need to discuss this numbering, i.e., for 6 components of symmetric tensor per vertex (i.e., 0 through 5).
Author
There was a problem hiding this comment.
function now uses one 2d array instead of six 1d arrays.
src/pmpo_c.cpp
Outdated
| Kokkos::deep_copy(arrayHost, array_d); | ||
| } | ||
|
|
||
| void polympo_setMeshVtxStrainRate_f(MPMesh_ptr p_mpmesh, const int nVertices, const double *xNormal, const double *yNormal, const double *zNormal, const double *xyShear, const double *xzShear, const double *yzShear){ |
There was a problem hiding this comment.
Need to discuss if each component (of the 6 components of symmetric tensor) will be given as a separate array.
Author
There was a problem hiding this comment.
It has been converted to take one 2d array instead
test/testFortran.f90
Outdated
| call assert((yArray(i) .eq. value2-i), "Assert MeshVel v-component Velocity Fail") | ||
| end do | ||
|
|
||
| !VtxStrainRate needs 6 arrays, using x,y,zArrays for all 6 |
There was a problem hiding this comment.
Only in this file, change 2d array Mesharray name to Mesharray_vel and use a new 2d array Mesharray_strainrate(numCompsStrainRate,nverts) for "VtxStrainRate" testing with 6 values per vertex
Angelyr
requested changes
Jun 4, 2024
…d array instead of 6 1d arrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set and get strain rate functions have been added, as well as code to test it.