Allow sasmodels.compare to use bumps webview instead of wx#651
Merged
Allow sasmodels.compare to use bumps webview instead of wx#651
Conversation
pkienzle
pushed a commit
that referenced
this pull request
Jul 15, 2025
Collaborator
|
@pkienzle - please fix the merge conflicts so this can be reviewed |
krzywon
reviewed
Mar 2, 2026
Comment on lines
+1261
to
+1262
| elif arg == '-edit': opts['explore'] = 'web' | ||
| elif arg == '-wxedit': opts['explore'] = 'wx' |
Collaborator
There was a problem hiding this comment.
New options and behavior with no documentation updates?
krzywon
approved these changes
Mar 2, 2026
Collaborator
krzywon
left a comment
krzywon
left a comment
There was a problem hiding this comment.
The new options should be documented, but otherwise this works fine. Feel free to merge as-is, or update the docs and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
python -m sasmodels.compare -edit sphere@hardspherestarts up a model explorer with sliders to change the parameter values.The new 1.0 bumps release adds a browser interface using the bumps.webview server.
This PR now uses webview to explore the model. If instead it is started with
... -wxeditit will use the old bumps wx GUI.This PR also turns off the fixed y limits on the plot, though making it easy to toggle in the code.
Structure factor models are now drawn using linear-linear rather than log-log. Other models can be set to linear q by adding "-zero" to the options, and linear I(q) by adding "-linear". Changing structure factor models back to log-log will require toggling in the code.
sasmodels.compare is only used for developing new models. It is not used by sasview or other applications.