refactor: replace `errgo` and `pkg/errors` with `github.com/Scalingo/go-utils/errors/v3`#1196

Merged

EtienneM merged 10 commits intomasterfrom

build/remove_errgo

Mar 5, 2026

Member

EtienneM commented Mar 4, 2026 •

edited

Loading

Add a changelog entry in the section "To Be Released" of CHANGELOG.md

EtienneM self-assigned this

EtienneM changed the base branch from master to feat/pagination/json_tag

March 4, 2026 07:33

EtienneM force-pushed the build/remove_errgo branch from c3fbc95 to 09876a8 Compare

March 4, 2026 09:39

semgrep-code-scalingo bot reviewed

View reviewed changes

update/check.go Outdated Show resolved Hide resolved

semgrep-code-scalingo bot reviewed

View reviewed changes

scalingo/main.go Outdated Show resolved Hide resolved

semgrep-code-scalingo bot reviewed

View reviewed changes

detect/app.go Outdated Show resolved Hide resolved

EtienneM force-pushed the build/remove_errgo branch from 5fd4404 to 5477e2b Compare

March 4, 2026 10:08

EtienneM force-pushed the feat/pagination/json_tag branch 2 times, most recently from c8add97 to 5c42416 Compare

March 4, 2026 16:24

Base automatically changed from feat/pagination/json_tag to master

March 4, 2026 16:56

EtienneM added 8 commits

March 5, 2026 08:53


          refactor: replace errgo with github.com/Scalingo/go-utils/errors/v2

bb0bfb4


          build(deps): update github.com/Scalingo/go-utils/errors from v2 to v3

084de85


          refactor: replace pkg/errors with `github.com/Scalingo/go-utils/err…

97ffdc3

…ors/v3`


          refactor: better wrapping message

702c10e


          refactor: group Scalingo dependencies

ec96f9c


          refactor: use the root context everywhere

c4c0f69


          fix: last small changes

3a1675f


          fix: merge conflicts

d5fd770

EtienneM force-pushed the build/remove_errgo branch from 70613aa to d5fd770 Compare

March 5, 2026 08:01

EtienneM marked this pull request as ready for review

March 5, 2026 08:07

EtienneM requested a review from a team as a code owner

March 5, 2026 08:07

EtienneM requested review from SCedricThomas and removed request for a team

March 5, 2026 08:07


          docs(changelog): missing entry

35a9bab

SCedricThomas reviewed

View reviewed changes

Contributor

SCedricThomas left a comment

Just some questions and fix to make. Thanks for taking care of this

env/display.go Outdated

               		}
               	}
-              	return "", errors.New("environment variable not found")
+              	return "", stderrors.New("environment variable not found")

Contributor

SCedricThomas Mar 5, 2026

issue: you should use the go-utils/error/v3 package as you have access to a context

cmd/integration_link.go Outdated

+              			return errors.Wrapf(ctx, err, "error parsing hours")
+              		}
+              		if i < 0 {
+              			return stderrors.New("must be positive")

Contributor

SCedricThomas Mar 5, 2026

question: can we use go-utils/error/v3 errors here? I saw that we are capturing the parent scope context but it should be possible as you used it to call errors.Wrapf on line 506

cmd/integration_link.go Outdated

+              	return func(ans any) error {
+              		str, ok := ans.(string)
+              		if !ok {
+              			return stderrors.New("must be a string")

Contributor

SCedricThomas Mar 5, 2026

question: can we use go-utils/error/v3 errors here? I saw that we are capturing the parent scope context but it should be possible as you used it to call errors.Wrapf on line 506

cmd/integration_link.go Outdated

               	var params scalingo.SCMRepoLinkCreateParams
               	if config.C.DisableInteractive {
-              		return params, errors.New("need at least one integration link parameter")
+              		return params, stderrors.New("need at least one integration link parameter")

Contributor

SCedricThomas Mar 5, 2026

issue: you should use the go-utils/errors/v3 package here

cmd/integration_link.go Outdated

               			noAutoDeploy := c.Bool("no-auto-deploy")
               			if autoDeploy && noAutoDeploy {
-              				errorQuitWithHelpMessage(ctx, errors.New("cannot define both auto-deploy and no-auto-deploy"), c, "integration-link-update")
+              				errorQuitWithHelpMessage(ctx, stderrors.New("cannot define both auto-deploy and no-auto-deploy"), c, "integration-link-update")

Contributor

SCedricThomas Mar 5, 2026

question: Why not using go-utils/errors/v3 package here? We have access to a context

cmd/integration_link.go Outdated

               			if allowReviewAppsFromForks && noAllowReviewAppsFromForks {
-              				errorQuitWithHelpMessage(ctx, errors.New("cannot define both allow-review-apps-from-forks and no-allow-review-apps-from-forks"), c, "integration-link-update")
+              				errorQuitWithHelpMessage(ctx, stderrors.New("cannot define both allow-review-apps-from-forks and no-allow-review-apps-from-forks"), c, "integration-link-update")

Contributor

SCedricThomas Mar 5, 2026

question: Why not using go-utils/errors/v3 package here? We have access to a context

cmd/integration_link.go Outdated

               			if awareOfSecurityRisks && !c.IsSet("allow-review-apps-from-forks") {
-              				errorQuitWithHelpMessage(ctx, errors.New("flag --aware-of-security-risks must be used in conjunction with --allow-review-apps-from-forks"), c, "integration-link-update")
+              				errorQuitWithHelpMessage(ctx, stderrors.New("flag --aware-of-security-risks must be used in conjunction with --allow-review-apps-from-forks"), c, "integration-link-update")

Contributor

SCedricThomas Mar 5, 2026

question: Why not using go-utils/errors/v3 package here? We have access to a context

cmd/integration_link.go Outdated

               				if awareOfSecurityRisks && !c.IsSet("allow-review-apps-from-forks") {
-              					errorQuitWithHelpMessage(ctx, errors.New("flag --aware-of-security-risks must be used in conjunction with --allow-review-apps-from-forks"), c, "integration-link-create")
+              					errorQuitWithHelpMessage(ctx, stderrors.New("flag --aware-of-security-risks must be used in conjunction with --allow-review-apps-from-forks"), c, "integration-link-create")

Contributor

SCedricThomas Mar 5, 2026

question: Why not using go-utils/errors/v3 package here? We have access to a context

cmd/integration_link.go Outdated

               				if allowReviewAppsFromForks && noAllowReviewAppsFromForks {
-              					errorQuitWithHelpMessage(ctx, errors.New("cannot define both allow-review-apps-from-forks and no-allow-review-apps-from-forks"), c, "integration-link-create")
+              					errorQuitWithHelpMessage(ctx, stderrors.New("cannot define both allow-review-apps-from-forks and no-allow-review-apps-from-forks"), c, "integration-link-create")

Contributor

SCedricThomas Mar 5, 2026

question: Why not using go-utils/errors/v3 package here? We have access to a context

cmd/integration_link.go Outdated

               				noDestroyOnStale := c.Bool("no-destroy-on-stale")
               				if destroyOnStale && noDestroyOnStale {
-              					errorQuitWithHelpMessage(ctx, errors.New("cannot define both destroy-on-stale and no-destroy-on-stale"), c, "integration-link-create")
+              					errorQuitWithHelpMessage(ctx, stderrors.New("cannot define both destroy-on-stale and no-destroy-on-stale"), c, "integration-link-create")

Contributor

SCedricThomas Mar 5, 2026

question: Why not using go-utils/errors/v3 package here? Same for above

Member Author

EtienneM Mar 5, 2026

Nice catch, I fixed all your comments in b662bda


          refactor: replace errors with github.com/Scalingo/go-utils/errors/v3

b662bda

EtienneM requested a review from SCedricThomas

March 5, 2026 10:27

SCedricThomas approved these changes

View reviewed changes

EtienneM merged commit a901590 into master

7 checks passed

EtienneM deleted the build/remove_errgo branch

March 5, 2026 13:35

EtienneM mentioned this pull request

feat(error): handle 422 errors from the API #1198

Open

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet