QA: restore JET execution + remove broken duplicate QA.yml#143
Merged
Conversation
CI centralization (SciML#141) wired a new [QA] test group but left two regressions: 1. The standalone .github/workflows/QA.yml was not removed. It still runs `julia --project=test/qa test/qa/runtests.jl`, but SciML#141 deleted test/qa/runtests.jl — so the QA.yml jobs ("QA - Julia lts" / "QA - Julia 1") are red on master, and they duplicate the new [QA] group (run via the grouped-tests.yml caller from test/test_groups.toml). Delete QA.yml; the [QA] group supersedes it. 2. The old QA.yml enforced a real JET analysis (JET.report_package(MultiScaleArrays; target_modules=(MultiScaleArrays,)) with @test length(reports)==0) and it PASSED on master. The new test/qa/qa.jl ran NO JET — only `@test_broken false`. A passing enforced check was silently dropped. Restore the exact old JET check and enforce it. Verified locally (julia +1.11, GROUP=QA): with the qa env resolving the same stack the old standalone env did (DiffEqBase 7.5.5, JET 0.9.20), the restored check reports 0 findings under target_modules=(MultiScaleArrays,) and passes (JET testset: 1 Pass). The full QA group is green: 7 Pass / 2 Broken / 0 Fail (the 2 Broken are the pre-existing Aqua ambiguities/deps_compat markers from issue SciML#142, unchanged here). Note: the DiffEqBase.alg_needs_extra_process finding listed in SciML#142 comes from the stricter JET.test_package(target_defined_modules=true), not from the check that was actually dropped — target_modules=(MultiScaleArrays,) attributes that undefined-binding to the DiffEqBase frame and filters it out. This restores the historical enforced check; it is not a test-logic change. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI centralization (#141) wired a new
[QA]test group but left two regressions on master:Broken duplicate workflow. The standalone
.github/workflows/QA.ymlwas not removed by Canonical CI: grouped-tests.yml + root test/test_groups.toml #141. It still runsjulia --project=test/qa test/qa/runtests.jl, but Canonical CI: grouped-tests.yml + root test/test_groups.toml #141 deletedtest/qa/runtests.jl. So theQA - Julia lts/QA - Julia 1jobs are red on master, and they duplicate the new[QA]group (which runs via thegrouped-tests.yml@v1caller inTests.yml, dispatched fromtest/test_groups.toml).A passing enforced check was silently dropped. The old
QA.ymlenforced a real JET analysis —JET.report_package(MultiScaleArrays; target_modules=(MultiScaleArrays,))with@test length(reports)==0— and it passed on master. The newtest/qa/qa.jlran no JET at all, only@test_broken false.Fix
.github/workflows/QA.yml— the[QA]group supersedes it; this removes the broken, duplicate jobs.test/qa/qa.jl, enforced with@test(not skipped). The Aqua@test_brokenmarkers (ambiguities + deps_compat, issue QA: Aqua/JET findings marked @test_broken pending fix #142) are left unchanged — they are a separate, still-open concern and out of scope here.Local verification (
julia +1.11,GROUP=QA)The
test/qaenv resolves the same stack the old standalone env did (DiffEqBase 7.5.5, JET 0.9.20). The restored check reports 0 findings undertarget_modules=(MultiScaleArrays,):Full QA group via
Pkg.test()withGROUP=QA(exit 0):The 2 Broken are the pre-existing Aqua markers from #142; 0 Fail / 0 Error.
Note on the #142 JET finding
The
DiffEqBase.alg_needs_extra_processfinding listed in #142 comes from the stricterJET.test_package(target_defined_modules=true), not from the check that was actually dropped. Withtarget_modules=(MultiScaleArrays,), JET attributes that undefined-binding to the DiffEqBase virtual-toplevel frame and the module filter drops it (confirmed locally:report_packagewithouttarget_modulesdoes surface it, 3 reports; with the filter, 0). This PR restores the historical enforced check verbatim — it is not a test-logic change. Thesrc/diffeq.jl:427source bug (usingDiffEqBase.instead ofStochasticDiffEq.) is real and still tracked in #142 for a source-level fix.Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code