pyproject.toml fixes#260
Open
trexfeathers wants to merge 4 commits intoSciTools:mainfrom
Open
Conversation
trexfeathers
commented
Apr 29, 2026
| # We have agreed that we will permanently ignore the ruff rules in this ignore list. | ||
| # We have agreed that we will permanently ignore the ruff rules in the first half of this ignore list. | ||
| ignore = [ | ||
| # NOTE: Non-permanent exclusions should be added to the ".ruff.toml" file. |
Contributor
Author
There was a problem hiding this comment.
We discussed this at length while producing this wiki page:
https://github.com/SciTools/.github/wiki/Linting
We agreed that we preferred to keep everything within pyproject.toml
stephenworsley
requested changes
Apr 30, 2026
Contributor
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Looks good, just one comment that I think could do with clarifying.
|
|
||
| [tool.repo-review] | ||
| # A list of the currently failing repo-review checks, to be fixed later, different for every repository. | ||
| # A list of the currently failing repo-review checks, possibly to be fixed later, different for every repository. |
Contributor
There was a problem hiding this comment.
This would be more clear written in the same form as the ruff comment below, i.e.
"We have agreed that we will permanently ignore the ... in the first half of this ignore list."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of things I spotted while aligning Iris with our agreed templating
@scitools-templating: please no update notification on: iris