Skip to content

TST: correct skip_plot marker#7163

Merged
trexfeathers merged 1 commit into
SciTools:mainfrom
rcomer:pytest-skipif
Jun 22, 2026
Merged

TST: correct skip_plot marker#7163
trexfeathers merged 1 commit into
SciTools:mainfrom
rcomer:pytest-skipif

Conversation

@rcomer

@rcomer rcomer commented Jun 20, 2026

Copy link
Copy Markdown
Member

Description

Pytest just fixed a bug whereby the --strict-markers option was being ignored pytest-dev/pytest#14443

#7162 is therefore failing because skipIf is an unknown marker. I assume it should be skipif. I attempted to make a Matplotlib-less dev environment to check that this now works, but found that you can't even import iris.cube without Cartopy being installed, and Matplotlib has been a required dependency of Cartopy for a while now.

    import iris.cube
lib/iris/cube.py:42: in <module>
    import iris._merge
lib/iris/_merge.py:28: in <module>
    import iris.coords
lib/iris/coords.py:40: in <module>
    import iris.util
lib/iris/util.py:40: in <module>
    from iris.coord_systems import GeogCS
lib/iris/coord_systems.py:19: in <module>
    import cartopy.crs as ccrs
E   ModuleNotFoundError: No module named 'cartopy'

Checklist

Important

The Iris core developers are here to help! If anything below is unclear, just post a comment asking for help 😊


Tip

Things you can trigger on this PR:

  • Add this label to trigger benchmarks: benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
  • Visit this URL - swapping 9999 for this PR's number - to re-trigger the CLA check:
    https://cla-assistant.io/check/SciTools/iris?pullRequest=9999

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (3f0dd8d) to head (335eff8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7163   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files          91       91           
  Lines       24983    24983           
  Branches     4685     4685           
=======================================
  Hits        22524    22524           
  Misses       1682     1682           
  Partials      777      777           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trexfeathers trexfeathers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rcomer!

@trexfeathers trexfeathers merged commit 2ad53e9 into SciTools:main Jun 22, 2026
22 checks passed
@rcomer rcomer deleted the pytest-skipif branch June 22, 2026 14:14
tkknight added a commit to tkknight/iris that referenced this pull request Jun 22, 2026
* upstream/main:
  TST: correct skip_plot marker (SciTools#7163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants