Fix benchmarks link in PR checklist#7164
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7164 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 91 91
Lines 24983 24983
Branches 4685 4685
=======================================
Hits 22524 22524
Misses 1682 1682
Partials 777 777 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pp-mo
left a comment
There was a problem hiding this comment.
I'm puzzled.
The link as-is does work, Sphinx allows relative paths, why do we not want them?
Plus, the links are all to "latest" which seems slightly unwise anyway : don't we want each docs version to be self-complete ?
It only works if you're viewing the template file. If you're viewing the checklist within an actual pull request, it doesn't work. This is how I missed it in the first place.
That's important in this case, since developer guidelines can change between releases. Examples:
... in both cases, following the guidance in the |
Description
Was previously using
..relative notation, but visiting a file in GitHub actually requires ablobURL.Checklist
Important
The Iris core developers are here to help! If anything below is unclear, just post a comment asking for help 😊
(further reading)
Tip
Things you can trigger on this PR:
9999for this PR's number - to re-trigger the CLA check:https://cla-assistant.io/check/SciTools/iris?pullRequest=9999