Add option for steps in Cube rolling windows - #7236
Open
mo-AndrewCreswick wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7236 +/- ##
==========================================
+ Coverage 90.34% 90.42% +0.07%
==========================================
Files 92 93 +1
Lines 25336 25814 +478
Branches 4731 4796 +65
==========================================
+ Hits 22890 23342 +452
- Misses 1675 1693 +18
- Partials 771 779 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a
stepargument toiris.cube.Cube.rolling_windowmethod to make use of the full functionality available iniris.util.rolling_window. A default argument ofstep=1ensures backwards compatibility.Unit tests added to test the aggregation over rolling windows with a step between windows and also to test that coordinates are handled correctly with a step. The behaviour of the window creation with steps is tested more thoroughly in the unit tests for
iris.util.rolling_window.I'm not sure if benchmarking is required for this PR so have not added the label for now.
Checklist
Important
The Iris core developers are here to help! If anything below is unclear, just post a comment asking for help 😊
(further reading)
Tip
Things you can trigger on this PR:
9999for this PR's number - to re-trigger the CLA check:https://cla-assistant.io/check/SciTools/iris?pullRequest=9999