The "Gaelic, Scottish (gd)" #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alization-team.md Fixes the nested language list by making the semicolon character replace the comma as the list denominator. Fixes the issue with the "Gaelic, Scottish"; the list should now abide by all English grammar rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a longtime active Russian translator for Scratch Addons, and while translating the website I found a little issue with how
docs/localization/joining-the-localization-team.mdlists off the supported languages in Scratch Addons.The way this manifests is in the "Gaelic, Scottish" entry, which I can only assume is one entry, simply having a comma in it. So what's the problem? The problem is that the entire rest of the list uses commas too, to denote each language. Since the "Gaelic, Scottish" entry uses a comma too, it looks like Gaelic and Scottish are two separate languages, which I don't believe is true.
To solve this little problem, I came up with a couple of solutions. We could either make the list use semicolons (
;) instead of commas (,) OR we could remove the comma from the entry in any way. Both solutions are valid, leading to a list that follows all rules of the English language.In this pull request, I implemented the first, semicolon solution, but You could edit this request to use the other solution (or any other archaic solution that is somehow distinct). I like the semicolon solution a bit more, though))
So yeah, I think that's about it. I'll try to respond as fast as possible if there are any questions, thank You very much for reading this!