Skip to content

Conversation

@shs96c
Copy link
Member

@shs96c shs96c commented Dec 19, 2025

This also updates all the bazel deps we have to their latest versions.

@selenium-ci selenium-ci added C-java Java Bindings B-atoms JavaScript chunks generated by Google closure B-build Includes scripting, bazel and CI integrations B-devtools Includes everything BiDi or Chrome DevTools related B-support Issue or PR related to support classes labels Dec 19, 2025
@selenium-ci
Copy link
Member

Thank you, @shs96c for this code suggestion.

The support packages contain example code that many users find helpful, but they do not necessarily represent
the best practices for using Selenium, and the Selenium team is not currently merging changes to them.

After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium
to work, we will likely close the PR.

We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks.
If you have any questions, please contact us

shs96c and others added 5 commits December 22, 2025 11:08
We see intermittent failures when builds fail on Windows when uploading
logs. This is because:

 1. The **/*.log glob pattern in the "Upload test logs" step scans the
    entire workspace, including bazel-out directories.
 2. Bazel on Windows creates junction points for the `bazel-bin`,
    `bazel-out`, `bazel-testlogs`, and so on directories.
 3. The `upload-artifact` action has known issues with symlinks/junctions
    on Windows - when it tries to `stat()` these paths, it can fail with
    EPERM.

The intermittent nature is because:
 1. The step only runs when tests fail.
 2. The specific files/directories in bazel-out depend on what was built
    in that run Windows file locking and junction handling can be
    inconsistent.
@titusfortner
Copy link
Member

@shs96c should we remove MODULE.bazel.lock from .gitignore with this release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-atoms JavaScript chunks generated by Google closure B-build Includes scripting, bazel and CI integrations B-devtools Includes everything BiDi or Chrome DevTools related B-support Issue or PR related to support classes C-java Java Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants