-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[bazel] Update to Bazel 8 #16757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[bazel] Update to Bazel 8 #16757
Conversation
|
Thank you, @shs96c for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
We see intermittent failures when builds fail on Windows when uploading
logs. This is because:
1. The **/*.log glob pattern in the "Upload test logs" step scans the
entire workspace, including bazel-out directories.
2. Bazel on Windows creates junction points for the `bazel-bin`,
`bazel-out`, `bazel-testlogs`, and so on directories.
3. The `upload-artifact` action has known issues with symlinks/junctions
on Windows - when it tries to `stat()` these paths, it can fail with
EPERM.
The intermittent nature is because:
1. The step only runs when tests fail.
2. The specific files/directories in bazel-out depend on what was built
in that run Windows file locking and junction handling can be
inconsistent.
|
@shs96c should we remove |
This also updates all the bazel deps we have to their latest versions.