-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[build] add explicit permissions to github workflows #16774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
cgoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as it works.
What are you using for security scanning? I ran our workflows through this a while back and it found a lot of issues: https://github.com/zizmorcore/zizmor
|
@cgoldberg this was just qodo complaining in the PRs I was making that changed things in the workflow |
User description
Security checkers have been complaining when I update a workflow that doesn't have restrictive permissions, so I've added them to everything. I think these are right.
PR Type
Enhancement
Description
Add explicit read permissions to all GitHub workflows
Add write permissions where workflows need to modify repository content
Improve security posture by following least privilege principle
Prevent security checker warnings on workflow updates
Diagram Walkthrough
File Walkthrough
16 files
Add read-only permissions to dotnet CI workflowAdd read-only permissions to grid UI CI workflowAdd read-only permissions to Java CI workflowAdd read-only permissions to Python CI workflowAdd read-only permissions to RBE CI workflowAdd permissions with write access for dependency pinningAdd read-only permissions to Ruby CI workflowAdd read-only permissions to Rust CI workflowAdd read-only permissions to main CI workflowAdd read-only workflow permissions with job-level writeAdd read-only permissions to release mirror workflowAdd permissions with selective write for release creationAdd read-only permissions to browser pinning workflowAdd read-only permissions to pre-release workflowAdd read-only permissions to release staging workflowAdd read-only permissions to documentation update workflow