Expose IntegerValue::as_i64 and RelayFieldMultipliers::for_connection - #145
Merged
Merged
Conversation
`IntegerValue` offered `as_i32` and `as_u64` but kept `as_i64` private, so a caller that checks the signed 64-bit range had to go through the decimal text. Make it public. `RelayCostComputer` was the only way to get Relay connection multipliers, and it identifies connections through the `@cost(kind: "connection")` directive. A cost computer that identifies connections another way had to copy the `first`/`last` sizing logic. Move that logic onto `RelayFieldMultipliers::for_connection`, export the type, and have `RelayCostComputer` use it.
adampetro
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntegerValueofferedas_i32andas_u64but keptas_i64private, so a caller that checks the signed 64-bit range had to go through the decimal text. Make it public.RelayCostComputerwas the only way to get Relay connection multipliers, and it identifies connections through the@cost(kind: "connection")directive. A cost computer that identifies connections another way had to copy thefirst/lastsizing logic. Move that logic ontoRelayFieldMultipliers::for_connection, export the type, and haveRelayCostComputeruse it.Both of these will be used in bluejay-rb