Draft
Conversation
When checkout completes successfully, set a checkoutCompleted flag via a callback from CheckoutWebViewEventProcessor to CheckoutDialog. If a network error subsequently triggers the recovery flow, the flag prevents a futile recovery attempt against a cart that has already been consumed by the completed order. Without this guard, the recovery flow loads the original cart URL, gets a 404 (cart no longer exists), and shows the buyer an error for a checkout that actually succeeded. Co-authored-by: Daniel Kift <daniel.kift@shopify.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checkout completes successfully, set a checkoutCompleted flag via a callback from CheckoutWebViewEventProcessor to CheckoutDialog. If a network error subsequently triggers the recovery flow, the flag prevents a futile recovery attempt against a cart that has already been consumed by the completed order.
Without this guard, the recovery flow loads the original cart URL, gets a 404 (cart no longer exists), and shows the buyer an error for a checkout that actually succeeded.
What changes are you making?
How to test
Before you merge
Important
Checklist for releasing a new version
build.gradlefileTip
See the Contributing documentation for instructions on how to publish a new version of the library.