Add Camera API type definitions #3597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatbattk
force-pushed
the
20644-pos-camera-api
branch
from
4798f27 to
808eb9f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20251125223311" |
vctrchu
reviewed
Nov 28, 2025
packages/ui-extensions/src/surfaces/point-of-sale/api/action-target-api/action-target-api.ts
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/api/camera-api/camera-api.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/api/camera-api/camera-api.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/api/camera-api/camera-api.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/api/camera-api/camera-api.ts
Show resolved
Hide resolved
andy-chhuon
force-pushed
the
20644-pos-camera-api
branch
from
808eb9f to
d971e35
Compare
vctrchu
reviewed
Dec 1, 2025
packages/ui-extensions/src/surfaces/point-of-sale/api/camera-api/camera-api.ts
Outdated
Show resolved
Hide resolved
vctrchu
approved these changes
Dec 1, 2025
Contributor
vctrchu
left a comment
vctrchu
left a comment
There was a problem hiding this comment.
LGTM, just the one comment about removing the POS GO reference
fatbattk
force-pushed
the
20644-pos-camera-api
branch
from
d971e35 to
94bf96c
Compare
fatbattk
force-pushed
the
20644-pos-camera-api
branch
from
94bf96c to
4cf982d
Compare
packages/ui-extensions/src/surfaces/point-of-sale/api/camera-api/camera-api.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/api/camera-api/camera-api.ts
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/api/camera-api/camera-api.ts
Show resolved
Hide resolved
fatbattk
force-pushed
the
20644-pos-camera-api
branch
from
4cf982d to
101406b
Compare
Co-authored-by: Han T. <[email protected]>
andy-chhuon
force-pushed
the
20644-pos-camera-api
branch
from
101406b to
4603535
Compare
andy-chhuon
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21032
Background
Add type definitions for Camera API
Checklist