[3.0] Add logException to ErrorHandler#9183
Open
jdarwood007 wants to merge 1 commit intoSimpleMachines:release-3.0from
Open
[3.0] Add logException to ErrorHandler#9183jdarwood007 wants to merge 1 commit intoSimpleMachines:release-3.0from
jdarwood007 wants to merge 1 commit intoSimpleMachines:release-3.0from
Conversation
We can now call errorHandler::LogException(\Exception) and have SMF handle the work of putting the pieces together to log the data. Additionally a new known_exception_types map is added to allow us to natively map some known or excepted types to the known_error_types. This wasn't passed into our hooks as we want to carefully add to this list since a generalization of a exception class to a error type may lead to false categorization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can now call errorHandler::LogException(\Exception) and have SMF handle the work of putting the pieces together to log the data.
Additionally a new known_exception_types map is added to allow us to natively map some known or excepted types to the known_error_types. This wasn't passed into our hooks as we want to carefully add to this list since a generalization of a exception class to a error type may lead to false categorization.