Make structure icon recovery state-sourced after runtime renderer disruption#3
Closed
Make structure icon recovery state-sourced after runtime renderer disruption#3
Conversation
Co-authored-by: Skigim <217411484+Skigim@users.noreply.github.com>
Co-authored-by: Skigim <217411484+Skigim@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate rare runtime rendering bug in Skigim/OpenFrontIO
Recover structure rendering from runtime layer disruption and add render debug hooks
Mar 20, 2026
Co-authored-by: Skigim <217411484+Skigim@users.noreply.github.com>
Copilot
AI
changed the title
Recover structure rendering from runtime layer disruption and add render debug hooks
Make structure icon recovery state-sourced after runtime renderer disruption
Mar 20, 2026
|
Owner
|
Closing this fork-local PR in favor of the upstream PR: openfrontio#3480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description:
I don't have a clean repro for the mid-match structure icon issue yet, so this PR is meant to reduce the chance of structure icons getting lost after a renderer reset.
This also does not address the separate issue where structure icons sometimes fail to show from game start.
This changes structure icon rendering to rebuild from the current game state instead of mostly waiting for future unit updates.
Main changes:
StructureIconsLayer.redraw()rebuild structure icons fromgame.units()Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
skigim