Setup DistNeighborloader for graph store sampling by kmontemayor2-sc · Pull Request #432 · Snapchat/GiGL

kmontemayor2-sc · 2026-01-10T00:07:57Z

Scope of work done

Setting up distributed neighborloader for graph store (GS) mode.

In this change we:

Introduce RemoteDistDataset as an input for the loader
Allow the loader to take in list[Tensor] as inputs for GS sampling.
Add tests that the above work together :)

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

kmontemayor2-sc · 2026-01-10T00:08:10Z

/unit_test_py

kmontemayor2-sc · 2026-01-10T00:08:15Z

/integration_test

kmontemayor2-sc · 2026-01-10T00:08:20Z

/e2e_test

github-actions · 2026-01-10T00:08:24Z

GiGL Automation

@ 24:08:24UTC : 🔄 Python Unit Test started.

github-actions · 2026-01-10T00:08:29Z

GiGL Automation

@ 24:08:29UTC : 🔄 Integration Test started.

@ 01:08:15UTC : ✅ Workflow completed successfully.

github-actions · 2026-01-10T00:08:32Z

GiGL Automation

@ 24:08:31UTC : 🔄 E2E Test started.

mkolodner-sc

Thanks Kyle! Left a round of comments

kmontemayor2-sc · 2026-01-13T23:41:13Z

/unit_test_py

kmontemayor2-sc · 2026-01-13T23:41:20Z

/integration_test

github-actions · 2026-01-13T23:41:28Z

GiGL Automation

@ 23:41:27UTC : 🔄 Python Unit Test started.

github-actions · 2026-01-13T23:41:31Z

GiGL Automation

@ 23:41:31UTC : 🔄 Integration Test started.

@ 24:53:37UTC : ✅ Workflow completed successfully.

kmontemayor2-sc · 2026-01-14T00:06:12Z

/e2e_test

github-actions · 2026-01-14T00:06:23Z

GiGL Automation

@ 24:06:23UTC : 🔄 E2E Test started.

kmontemayor2-sc · 2026-01-14T17:55:36Z

/e2e_test

kmontemayor2-sc · 2026-01-14T17:55:42Z

/unit_test_py

kmontemayor2-sc · 2026-01-14T17:55:50Z

/integration_test

github-actions · 2026-01-14T17:55:51Z

GiGL Automation

@ 17:55:50UTC : 🔄 E2E Test started.

@ 19:13:17UTC : ✅ Workflow completed successfully.

github-actions · 2026-01-14T17:55:55Z

GiGL Automation

@ 17:55:55UTC : 🔄 Python Unit Test started.

@ 18:59:09UTC : ✅ Workflow completed successfully.

github-actions · 2026-01-14T17:56:05Z

GiGL Automation

@ 17:56:05UTC : 🔄 Integration Test started.

@ 18:59:57UTC : ✅ Workflow completed successfully.

mkolodner-sc

Thanks Kyle! Generally LGTM to me

kmontemayor2-sc · 2026-01-15T21:11:16Z

/unit_test_py

kmontemayor2-sc · 2026-01-15T21:11:22Z

/integration_test

kmontemayor2-sc · 2026-01-15T21:11:28Z

/e2e_test

github-actions · 2026-01-15T21:11:30Z

GiGL Automation

@ 21:11:30UTC : 🔄 Python Unit Test started.

@ 22:19:48UTC : ✅ Workflow completed successfully.

github-actions · 2026-01-15T21:11:37Z

GiGL Automation

@ 21:11:36UTC : 🔄 Integration Test started.

@ 22:11:08UTC : ✅ Workflow completed successfully.

github-actions · 2026-01-15T21:11:42Z

GiGL Automation

@ 21:11:42UTC : 🔄 E2E Test started.

@ 22:33:42UTC : ✅ Workflow completed successfully.

svij-sc

Thanks for addressing everything

LGTM beyond this thread:
https://github.com/Snapchat/GiGL/pull/432/changes#r2687675025

svij-sc · 2026-01-17T00:31:35Z

I will approve to unblock, but lets revisit the dictionary consideration here before calling this complete.

kmontemayor2-sc · 2026-01-17T01:07:18Z

I will approve to unblock, but lets revisit the dictionary consideration here before calling this complete.

Ack, I expect this to be a part of scale testing.

Setup DistNeighborloader for graph store sampling

4233f92

kmontemayor2-sc requested review from mkolodner-sc, nshah-sc, svij-sc, xgao4-sc, yliu2-sc and zfan3-sc as code owners January 10, 2026 00:07

cleanup

fa0bd9a

kmontemayor2-sc commented Jan 10, 2026

View reviewed changes

Comment thread python/gigl/distributed/graph_store/compute.py

Comment thread python/gigl/distributed/graph_store/storage_main.py Outdated

Comment thread python/gigl/distributed/distributed_neighborloader.py

mkolodner-sc reviewed Jan 13, 2026

View reviewed changes

svij-sc reviewed Jan 13, 2026

View reviewed changes

address comments

27a0e37

actually get edge types

922cfd2

kmontemayor2-sc commented Jan 14, 2026

View reviewed changes

Merge branch 'main' into kmonte/support-gs-for-neighbor-loader

9fca08a

kmontemayor2-sc mentioned this pull request Jan 15, 2026

Setup e2e integration test for graph store homogeneous inference #433

Merged

mkolodner-sc approved these changes Jan 15, 2026

View reviewed changes

Comment thread python/gigl/distributed/distributed_neighborloader.py Outdated

Comment thread python/gigl/distributed/distributed_neighborloader.py Outdated

kmonte added 2 commits January 15, 2026 19:55

Merge branch 'main' into kmonte/support-gs-for-neighbor-loader

81977e3

address comments

94b521f

svij-sc reviewed Jan 16, 2026

View reviewed changes

Comment thread python/gigl/distributed/distributed_neighborloader.py

kmontemayor2-sc enabled auto-merge January 17, 2026 00:16

svij-sc approved these changes Jan 17, 2026

View reviewed changes

kmontemayor2-sc added this pull request to the merge queue Jan 17, 2026

Merged via the queue into main with commit 9bb5d85 Jan 17, 2026
6 checks passed

kmontemayor2-sc deleted the kmonte/support-gs-for-neighbor-loader branch January 17, 2026 01:51

kmontemayor2-sc mentioned this pull request Feb 5, 2026

Update ABLP Loader in preparation for graph store #478

Merged

Conversation

kmontemayor2-sc commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kmontemayor2-sc commented Jan 10, 2026

Uh oh!

kmontemayor2-sc commented Jan 10, 2026

Uh oh!

kmontemayor2-sc commented Jan 10, 2026

Uh oh!

github-actions Bot commented Jan 10, 2026

GiGL Automation

Uh oh!

github-actions Bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

github-actions Bot commented Jan 10, 2026

GiGL Automation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkolodner-sc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kmontemayor2-sc commented Jan 13, 2026

Uh oh!

kmontemayor2-sc commented Jan 13, 2026

Uh oh!

github-actions Bot commented Jan 13, 2026

GiGL Automation

Uh oh!

github-actions Bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

kmontemayor2-sc commented Jan 14, 2026

Uh oh!

github-actions Bot commented Jan 14, 2026

GiGL Automation

Uh oh!

kmontemayor2-sc commented Jan 14, 2026

Uh oh!

kmontemayor2-sc commented Jan 14, 2026

Uh oh!

kmontemayor2-sc commented Jan 14, 2026

Uh oh!

github-actions Bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

github-actions Bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

github-actions Bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

Uh oh!

kmontemayor2-sc commented Jan 10, 2026 •

edited

Loading

github-actions Bot commented Jan 10, 2026 •

edited

Loading

github-actions Bot commented Jan 13, 2026 •

edited

Loading

github-actions Bot commented Jan 14, 2026 •

edited

Loading

github-actions Bot commented Jan 14, 2026 •

edited

Loading

github-actions Bot commented Jan 14, 2026 •

edited

Loading

github-actions Bot commented Jan 15, 2026 •

edited

Loading

github-actions Bot commented Jan 15, 2026 •

edited

Loading

github-actions Bot commented Jan 15, 2026 •

edited

Loading