Bump actions/checkout from 4.2.2 to 5.0.0#2
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.2.2...08c6903) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Author
|
Looks like actions/checkout is no longer a dependency, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/github_actions/actions/checkout-5.0.0
branch
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
Apr 18, 2026
…ate duplication Org-scan R4 #2: env.ts and env/helpers.ts exported the same three names with different semantics. Rather than preserving silent divergence, the root implementations now accept options to select either mode: - envAsBoolean(value, { trim }) — trim=true default; trim=false = strict - envAsNumber(value, { mode, allowInfinity }) — 'int' default; 'float' | allowInfinity for helpers parity - envAsString(value, { trim }) — trim=true default; trim=false preserves whitespace Legacy positional-default arguments still work (envAsNumber(null, 42), envAsString(null, 'x'), etc.). envAsString also coerces non-string positional defaults via String() for back-compat with existing tests. env/helpers.ts is now a thin wrapper that delegates to the root functions with the historical strict/float/preserve-whitespace modes pre-selected. All 132 env tests pass (both root and helpers suites).
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
May 7, 2026
…P1) Per "test them, don't dismiss them" feedback — the previous push punted on defensive catch branches as "low ROI". This lands targeted unit tests that mock the helper functions (`safeDelete[Sync]`, `safeMkdirSync`, `readFileUtf8Sync`, `cacache.safeGet`/`remove`) so the SUT's catch handlers actually fire under realistic failure modes. New test files (+22 tests): - test/unit/dlx/packages-errors.test.mts (8 tests). dlx/packages.ts: 71.4% → 96.4%. - test/unit/dlx/manifest-errors.test.mts (6 tests). dlx/manifest.ts: 86.0% → 88.8%. - test/unit/process-lock-errors.test.mts (3 tests). process-lock.ts: 86.7% → 87.8%. - test/unit/cache-with-ttl-errors.test.mts (5 tests). cache-with-ttl.ts: 89.9% → 94.9%. Also adds test/unit/utils/fs-error-helper.ts: a path-scoped fs spy helper for future tests that need errno-typed errors injected at the underlying fs op rather than at the helper layer. Project: 90.09% → 90.29% lines, 80.22% → 80.35% branches, 95.40% → 95.48% functions across 6875 passing tests (+22).
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
May 7, 2026
Push #2 P2 — network-mock based tests for paths that were previously "untestable" because they hit real network. New test files (+13 tests): - test/unit/releases-github-downloads-extras.test.mts (7 tests) Mocks getLatestRelease + getReleaseAssetUrl + httpDownload to cover: - toolPrefix tag resolution (success path) - toolPrefix throw when no matching release - "Either toolPrefix or tag must be provided" guard - explicit tag overrides toolPrefix lookup - cached-binary fast-path (httpDownload skipped) - downloadReleaseAsset throws on missing asset (string + object pattern) releases/github-downloads.ts: 80.0% → 100.0%. - test/unit/dlx/binary-download.test.mts (6 tests) Mocks httpDownload to cover downloadBinaryFile: - SRI integrity hash on success - existing-file fast-path skips download - matching integrity accepted - integrity mismatch throws + cleans up bad file - download failure wrapped with URL + dest context - sha256 option forwarded to httpDownload Project: 90.29% → 90.44% lines, 80.35% → 80.66% branches across 6888 passing tests (+13).
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
May 7, 2026
Push #2 P3 — materializes a fake Volta directory tree under tmp so resolveRealBinSync's Volta-cache branch (lines 390-464 in src/bin.ts) gets exercised. These paths were previously dead-on-non-Volta-runners. New: test/unit/bin-volta.test.mts (7 tests). Covers: - npm shim → image/npm/<version>/bin/npm-cli.js (success path) - npm fallback → node/<runtime>/lib/node_modules/npm - Returns input when neither npm path exists - Non-npm binary → packages/<pkg>/bin/<name> via tools/user/bin/<name>.json - Returns input when bin metadata json missing - Cache hit on repeated resolveRealBinSync call - basename === 'node' skips Volta branch entirely bin.ts: 65.0% → 72.9% (+7.9%). Project: 90.44% → 90.65% lines, 80.66% → 80.88% branches. Note found while writing this test: source `voltaPath = binPath.slice(0, voltaIndex)` gives the parent of `.volta/`, not `.volta/` itself. Tests match the existing behavior. If real Volta layout is `~/.volta/tools/...`, the slice should include `.volta/` — flagging for follow-up.
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
May 7, 2026
Push #2 P5 — pure-function tests for spawn error helpers. New: test/unit/spawn-error.test.mts (15 tests). Covers: - enhanceSpawnError: null/non-object/non-spawn passthroughs, in-place rewrite of synthetic 'command failed' errors, long-arg truncation (>100 chars), signal-vs-code message branch, stderr first-line inclusion + truncation (>200 chars), Buffer-typed stderr, cause preservation when wrapping non-synthetic errors, lazy stack-trace getter (both first and second access). - isSpawnError: positive (cmd+code), plain Error, non-object inputs. - spawn(): non-existent binary rejects with enhanced error. spawn.ts: 84.1% → 91.0% (+6.9%). Project: 90.76% → 90.77% lines, 80.95% → 80.99% branches. P4 archive-defenses test file dropped: tar-fs@3.1.2 leaks an async fs callback with null path after the SUT's destroy(), which vitest reports as an uncaught exception and can hang the worker pool when multiple destructive tests run sequentially. The defenses are real behavior; the test boundary just can't exercise them. Documented for future re-attempt after tar-fs upgrade or SUT refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/checkout from 4.2.2 to 5.0.0.
Release notes
Sourced from actions/checkout's releases.
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
08c6903Prepare v5.0.0 release (#2238)9f26565Update actions checkout to use node 24 (#2226)08eba0bPrepare release v4.3.0 (#2237)631c7dcUpdate package dependencies (#2236)8edcb1bUpdate CODEOWNERS for actions (#2224)09d2acaUpdate README.md (#2194)85e6279Adjust positioning of user email note and permissions heading (#2044)009b9aeDocumentation update - add recommended permissions to Readme (#2043)cbb7224Update README.md (#1977)3b9b8c8docs: update README.md (#1971)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)