Skip to content

ECHOES-1429 Add code color tokens#733

Merged
marciopmoreira6 merged 1 commit into
mainfrom
marcio/add-missing-code-tokens
Jul 15, 2026
Merged

ECHOES-1429 Add code color tokens#733
marciopmoreira6 merged 1 commit into
mainfrom
marcio/add-missing-code-tokens

Conversation

@marciopmoreira6

Copy link
Copy Markdown
Contributor

Part of ECHOES-1429

Summary

  • Add a canonical color-code-* token group for code rendering colors.
  • Organize the tokens under background, border, and text subgroups.
  • Regenerate themed design token CSS and JSON artifacts.

Validation

  • yarn build-tokens --brand=Brand-A
  • yarn prettier --check design-tokens/tokens/modes/dark.json design-tokens/tokens/modes/light.json src/generated/design-tokens-dark.css src/generated/design-tokens-light.css src/generated/design-tokens-themed.json
  • yarn ts-check
  • Rebuilt generated tokens again and confirmed the generated diff stayed stable.

Review Notes

  • New public design tokens should be reviewed by both design and development.

@netlify

netlify Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit 5409ae8
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/6a575073ad712500086dff4a
😎 Deploy Preview https://deploy-preview-733--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jul 15, 2026

Copy link
Copy Markdown

ECHOES-1429

Comment thread design-tokens/tokens/modes/dark.json
Comment thread design-tokens/tokens/modes/light.json
@gitar-bot

gitar-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 2 resolved / 2 findings

Introduces new public color-code-* design tokens, but requires design and development sign-off and correction of hardcoded hex values that should reference existing palette roles.

✅ 2 resolved
Quality: New color-code-* tokens need design + dev sign-off

📄 design-tokens/tokens/modes/dark.json:916-930 📄 design-tokens/tokens/modes/light.json:676-690
This PR introduces a new public color-code-* token group (background/border/text subgroups, 12 tokens per theme) exposed as --echoes-color-code-* CSS variables. Per the project's token policy, new public design tokens are a review checkpoint: confirm both a designer and a developer have signed off on the names, structure, and values before merge. Not a blocker, just a gate.

Quality: Code text tokens use hardcoded hex instead of palette refs

📄 design-tokens/tokens/modes/light.json:694-708 📄 design-tokens/tokens/modes/dark.json:934-948
Most values in these mode files resolve through palette/role references (e.g. {echoes.color.palette.grey.500}), but the new code text tokens hardcode raw hex — 8 in light.json (which previously had none) and the annotation/constant/comment/keyword/string/keyword-subtle/preprocessing-directive/default values in dark.json. These arbitrary colors bypass the palette and won't stay in sync if the palette changes. If matching palette entries exist, reference them; if these syntax-highlight colors are genuinely new primitives, add them to the palette layer and reference those tokens instead of inlining hex.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown

@marciopmoreira6
marciopmoreira6 merged commit dd2fbe1 into main Jul 15, 2026
14 checks passed
@marciopmoreira6
marciopmoreira6 deleted the marcio/add-missing-code-tokens branch July 15, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants