Fix unclosed file warnings in json.load() calls #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The json.load(open(...)) pattern leaves file handles open, causing ResourceWarning when Python is run with warnings enabled. This is particularly noisy when using multiprocessing, as each worker triggers the warning when importing the module. Changes: - neuropixels_tools.py: Use context manager in _load_np_probe_features() - testing.py: Use context manager when loading JSON schema Both files now properly close file handles using 'with' statements. Fixes issue reported for Python 3.14 on Linux with forkserver multiprocessing.
alejoe91
approved these changes
Jan 14, 2026
Member
|
Thanks @grahamfindlay ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json.load(open(...)) pattern leaves file handles open, causing ResourceWarning when Python is run with warnings enabled. This is particularly noisy when using multiprocessing, as each worker triggers the warning when importing the module.
Changes:
Both files now properly close file handles using 'with' statements.