Skip to content

[EchoLayer (Stag)] Changes to OAuth service and update undefined state #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
squireai-staging wants to merge 1 commit into from
Closed

[EchoLayer (Stag)] Changes to OAuth service and update undefined state #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions codex-vscode/src/services/oauth.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,17 @@ export class OAuthService implements IOAuthService {
() =>
async (uri: vscode.Uri, resolve: (userInfo: UserInfo) => void, reject: (err: any) => void): Promise<void> => {
this.clearCodeExchangePromise();
const parsed_query = this.parseQuery(uri) as AuthorizeResponse | ErrorResponse;
if ((parsed_query as AuthorizeResponse).code) {
const parsedQuery = this.parseQuery(uri) as AuthorizeResponse | ErrorResponse;
if ((parsedQuery as AuthorizeResponse).code) {
// Get code from URI, pass to our server to exchange for a JWT & user info.
const loginResponse = await AuthService.getAuthService().login((parsed_query as AuthorizeResponse).code);
const loginResponse = await AuthService.getAuthService().login((parsedQuery as AuthorizeResponse).code);
const userInfo = loginResponse.data;

resolve(userInfo);
} else {
reject({
errorType: (parsed_query as ErrorResponse).errorType,
errorMessage: (parsed_query as ErrorResponse).errorMessage,
errorType: (parsedQuery as ErrorResponse).errorType,
errorMessage: (parsedQuery as ErrorResponse).errorMessage,
});
}
};
Expand All @@ -79,3 +79,4 @@ export class OAuthService implements IOAuthService {
OAuthService.codeExchangePromise = undefined;
};
}