This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Mudit Gupta and Ryan Thomas Lynch Submission #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added getMostImpactfulDisasterByYear method, added constructor, proper getters, and passed JUnit :D
necessitated making new constructor for no year needed
one more JUnit hopefully
now returns String as needed
now passes JUnit 😄
created two new exceptions, CategoryNotDefinedException and YearNotDefinedException, and implemented them in the DD class to be thrown when the values for the getters of category and year are not defined.
cuz .class merge conflicts be botherin us @muditg317 helped by pointing out my cmd was in the wrong dir Co-Authored-By: Mudit Gupta <[email protected]>
realized that it causes the JUnit to fail as it was not expecting an exception, so now it returns null for an undefined category and "NoYr" for an undefined year
new library for running R from Java
…list indexing, finalized javadocs added consistency of calling each line of records "entry" functions based on disaster category are more time efficient because they only iterate over elements of the list with the correct category oversight of index out of bounds exception for while loops in functions based on disaster category read through and improved clarity of all javadocs
removed statement about R functionality
Author
|
We removed the R capability because it was so new to us and the libraries had poor documentation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial submission
Mudit Gupta and Ryan Thomas Lynch