Fix tstart and tseg recalculation on Lightcurve truncation#974
Draft
swapsha96 wants to merge 4 commits intoStingraySoftware:mainfrom
Draft
Fix tstart and tseg recalculation on Lightcurve truncation#974swapsha96 wants to merge 4 commits intoStingraySoftware:mainfrom
swapsha96 wants to merge 4 commits intoStingraySoftware:mainfrom
Conversation
…using AveragedCrossspectrum.
…StingrayTimeseries.truncate()` attribute update issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issue(s)/PR(s)
Fixes #910
Provide an overview of the implemented solution or the fix and elaborate on the modifications.
Replaced the calculations for new_ts.tstart and new_ts.tseg so they use the new time array and time bin instead.
Is there a new dependency introduced by your contribution? If so, please specify.
N/A
Any other comments?
No