Fix bad units in call to pvlib.pvsystem.sapm#155
Open
joseph-sch wants to merge 1 commit intoSunPower:masterfrom
Open
Fix bad units in call to pvlib.pvsystem.sapm#155joseph-sch wants to merge 1 commit intoSunPower:masterfrom
joseph-sch wants to merge 1 commit intoSunPower:masterfrom
Conversation
pvlib.pvsystem.sapm expects the irradiance in W/m2 so the irradiance values from `TEST_MAT` do *not* need to be divided by 1,000. This should fix a failed assertion in `example.py` at line 33.
Contributor
|
Just chiming in to say I think this would close #124 :) |
mikofski
approved these changes
Apr 6, 2022
Contributor
mikofski
left a comment
mikofski
left a comment
There was a problem hiding this comment.
Thanks for this! I agree with @kanderso-nrel . @markcampanelli do you have authority over pvmm?
Author
|
@mikofski and all, there does not seem to be a maintainer on the repository... pull requests are not being merged... According to #152 from @chetan201, the maintainer on behalf of SunPower should now be @ahoffmanSPWR Any way we could get the PRs merged? |
Contributor
|
Hi all - Thanks for the nudge here. I took over as admin after some personnel changes. Apologies for the delays. I'll take a look at these requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should we add tests to this module? There is an assertion in
example.pythat fails without this fix, but it's not exactly a unit test.