Open
Conversation
Member
|
@Florian-Merle Could you remove your second commit? cause this PR was abandonnes I think. |
Contributor
Author
As we discussed, I abandoned the idea of adding an expression field type, but this pr is still a work in progress |
GSadee
added a commit
to Sylius/SyliusGridBundle
that referenced
this pull request
Oct 8, 2025
Uptdate the CallableFieldType so it can be used with services. Available services are the one tagged with `sylius.grid_field_callable_service`. The documentation for this can be found in the second commit of this PR Sylius/Stack#245
GSadee
added a commit
to Sylius/Grid
that referenced
this pull request
Oct 8, 2025
Uptdate the CallableFieldType so it can be used with services. Available services are the one tagged with `sylius.grid_field_callable_service`. The documentation for this can be found in the second commit of this PR Sylius/Stack#245
Member
|
@Florian-Merle Do we close this PR? |
Member
|
@GSadee I've seen you've added a few commits, do you plan to continue this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on this other PR #228 that should be merged when a new version of the sylius grid bundle will be released, see #228 (comment)
The second commit of this PR adds the documentation for Sylius/SyliusGridBundle#368