Add changelog entry for RN 0.87 header fix + upgrade example app to RN 0.87 - #902
Merged
Merged
Conversation
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
Contributor
|
Investigation of the failing
Timeline / what changed:
Options: rerun later (Google may fix/roll back), skip the IMA test on web, or switch the web ad e2e to THEOplayer's CSAI integration. |
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #897 (now merged), which removed the
RCTRootContentViewimport from the iOS bridging header (removed in React Native 0.87, react/react-native@23ce90bd). That removal is safe: the only remainingRCTRootContentViewreferences are runtime string class-name lookups viafindParentViewOfType(["RCTRootContentView", "RCTRootComponentView"])inTHEOplayerRCTPresentationModeManager.swift.This PR:
[Unreleased](for Remove RctRootContentView which is removed in RN 0.87.0 #897 and the example upgrade).react-native→npm:react-native-tvos@^0.87.0-0,@react-native/{babel-preset,eslint-config,metro-config,typescript-config}→0.87.1, lockfile regenerated.reactstays at 19.2.3 (RN 0.87 peer range is^19.2.3);@react-native-community/cli*(20.2.0) andreact-native-svg(^15.15.5, already has the >0.84 Fabric guard) need no bump.Ads.spec.tsearly-returns whenPlatform.OS === 'web'): the IMA HTML5 SDK fails to issue its ad request from CI/datacenter environments (error 1005 before the VAST tag is fetched) — see the investigation in the PR comment. Native platforms keep running the test.Verified:
npm run lintinexample/ande2e/, rootnpm run lintandnpm run prettier.Link to Devin session: https://dolby.devinenterprise.com/sessions/5e6ace8f7b224b358e7dda531163ed01
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/5e6ace8f7b224b358e7dda531163ed01?variant=devin
Requested by: @tvanlaerhoven