Conversation
mttk
left a comment
There was a problem hiding this comment.
So, from what I understand, every exposed module would be importable by doing from podium import <module>.
In some cases, I would prefer if we maintained different submodules, for cases of implemented datasets (from podium.datasets import SST, IMDB) or preprocessing tools, etc.
How difficult/ugly do you think it would be to maintain some degree of import hierarchy?
FilipBolt
left a comment
There was a problem hiding this comment.
I like this change since it is sort of more in line what I see from more recent frameworks: flair, huggingface. I know a bit older frameworks like torch, numpy, or scikit-learn still have hierarchy, but if there is no performance difference I don't see much value in keeping imports separate.
|
@mttk |
Discussed this change with @mttk on Slack.
Features:
__init__.pybut only if the required dependencies are installed (pyarrow for DiskBackedDatasets, datasets for HFDatasetConverter, yake for YAKE).