Migrate catalog examples to React - #84
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (56)
📝 WalkthroughWalkthroughThe conformance catalog and 14 chart cases now use React TSX views. Mounting, controls, lifecycle handling, accessibility output, source rendering, and conformance tests were updated for React integration. ChangesReact conformance migration
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tannerlinsley
force-pushed
the
taren/react-catalog-examples
branch
from
August 11, 2026 22:28
58718e6 to
107bd20
Compare
tannerlinsley
marked this pull request as ready for review
August 11, 2026 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The catalog and example shells mixed chart definitions with manual element creation, mutation, selector rebinding, and listener cleanup. That obscured the intended React ownership boundary and made the examples poor copy-paste material.
Validation
pnpm exec tsc --noEmit --pretty falsepnpm --filter @charts-poc/conformance-example buildnode scripts/catalog-index.mjs --checkSummary by CodeRabbit
New Features
Bug Fixes
Tests