-
Notifications
You must be signed in to change notification settings - Fork 162
Fix type of findOne queries in Vue #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type tests reproducing issue #1095 where useLiveQuery with findOne() returns `ComputedRef<Array<T>>` instead of `ComputedRef<T | undefined>`. This differs from the React implementation which correctly types findOne() queries to return a single object or undefined. The tests currently fail, demonstrating the bug.
Update useLiveQuery types to use InferResultType<TContext> which correctly handles the SingleResult type marker, returning `T | undefined` for findOne() queries instead of always returning `Array<T>`. Changes: - Import InferResultType, SingleResult, NonSingleResult from @tanstack/db - Update UseLiveQueryReturn interface to use InferResultType<TContext> - Add UseLiveQueryReturnWithSingleResultCollection for singleResult collections - Add separate overloads for pre-created collections (NonSingleResult vs SingleResult) - Update runtime implementation to return first element for singleResult collections This aligns Vue adapter behavior with the React adapter. Fixes #1095
🦋 Changeset detectedLatest commit: 30be4dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 90.5 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.47 kB ℹ️ View Unchanged
|
4 tasks
1 task
KyleAMathews
approved these changes
Jan 15, 2026
Contributor
|
🎉 This PR has been released! Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1095