perf(vue-router): compact private reactivity - #7982
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 7a01168
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview5 package(s) bumped directly, 18 bumped as dependents. 🟩 Patch bumps
|
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will regress 8 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server request-churn (vue) |
706.1 KB | 3,383.6 KB | -79.13% |
| ❌ | Memory | mem server error-paths unmatched (react) |
317.5 KB | 626.6 KB | -49.33% |
| ❌ | Memory | mem server error-paths redirect (solid) |
388 KB | 707.7 KB | -45.17% |
| ❌ | Memory | mem client preload-churn (vue) |
737 KB | 1,042.5 KB | -29.3% |
| ❌ | Memory | mem client unique-location-churn (vue) |
999.3 KB | 1,231.2 KB | -18.83% |
| ❌ | Memory | mem server peak-large-page (react) |
1.7 MB | 1.8 MB | -6.17% |
| ❌ | Simulation | ssr server-fn during document ssr (react) |
62.9 ms | 66.2 ms | -4.96% |
| ❌ | Simulation | ssr assets linked-css control (vue) |
186.1 ms | 195.2 ms | -4.68% |
| ⚡ | Memory | mem server server-fn-churn (vue) |
4,147.3 KB | 270.2 KB | ×15 |
| ⚡ | Memory | mem server error-paths unmatched (vue) |
2,142.1 KB | 478.9 KB | ×4.5 |
| ⚡ | Memory | mem server error-paths redirect (vue) |
338.6 KB | 305.8 KB | +10.73% |
| ⚡ | Memory | mem server error-paths not-found (react) |
277.7 KB | 265.3 KB | +4.65% |
| ⚡ | Memory | mem client navigation-churn (solid) |
580.3 KB | 557.1 KB | +4.15% |
| ⚡ | Memory | mem client navigation-churn (vue) |
1.3 MB | 1.2 MB | +3.75% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/compact-vue-private-reactivity (7a01168) with main (697ebb6)
Summary
Bundle impact
Only the four Vue scenarios change; the other 13 are byte-identical. Every affected bundle is 130 raw bytes smaller. Gzip improves by 32-43 bytes and initial gzip by 33-45 bytes. Brotli changes by -50 to +25 bytes; the one +25 case is vue-start.full, which still improves by 32 gzip bytes.
For vue-router.full: -130 raw / -39 gzip / -22 Brotli bytes.
For vue-start.minimal: -130 raw / -43 gzip / -50 Brotli bytes.
The checked-in result report includes full hunk attribution, subset rejection data, artifact SHAs, and the selector composition ablation.
Validation