Skip to content

docs: use the dynamic README header endpoint - #349

Open
AlemTuzlak wants to merge 1 commit into
mainfrom
readme-header-endpoint
Open

docs: use the dynamic README header endpoint#349
AlemTuzlak wants to merge 1 commit into
mainfrom
readme-header-endpoint

Conversation

@AlemTuzlak

@AlemTuzlak AlemTuzlak commented Aug 3, 2026

Copy link
Copy Markdown

Adopts the dynamic README header endpoint added in TanStack/tanstack.com#1076,
which is merged and live.

Every README banner in this repo now points a <picture> at
https://tanstack.com/api/readme/ instead of a committed PNG. The endpoint
renders 1800x450 in light and dark, so a branding change lands in every README
at once and dark-mode readers get a dark banner.

What changed

  • 1 README(s) updated.

  • Light and dark served through <picture>, per GitHub's guidance. The trailing <img> stays the light variant, as the fallback for renderers that ignore <picture> (npm, most editors).

  • Deletes the now-unused media/header_store.png.

Verification

Every generated URL in this diff was requested against the live endpoint and
returned 200 image/png at 1800x450. git grep confirms no README still
references the old media/header_*.png path.

Heads up: deleting the committed PNG means npm pages for already-published
versions that embed the raw.githubusercontent.com/.../main/media/header_*.png
link will show a broken image, since that link is branch-pinned. New releases
pick up the endpoint URL.

Summary by CodeRabbit

  • Documentation
    • Updated the Store header image to adapt responsively to light and dark color schemes.
    • Improved image accessibility text and display sizing.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 683921a0-30d0-4406-8086-776e09a65fa6

📥 Commits

Reviewing files that changed from the base of the PR and between 7bccd2a and caae78e.

⛔ Files ignored due to path filters (1)
  • media/header_store.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • README.md

📝 Walkthrough

Walkthrough

The README header now uses a responsive <picture> element with light and dark TanStack-hosted image sources, updated alt text, and a fixed width.

Changes

README header

Layer / File(s) Summary
Responsive header image
README.md
The README replaces the local header_store.png image with light and dark sources in a responsive <picture> element. The image includes updated alt text and a fixed width.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: replacing the README header with a dynamic endpoint.
Description check ✅ Passed The description explains the changes, verification steps, deleted asset, and release impact, despite not reproducing the template headings and checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch readme-header-endpoint

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit caae78e

Command Status Duration Result
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 30s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-03 09:28:31 UTC

@pkg-pr-new

pkg-pr-new Bot commented Aug 3, 2026

Copy link
Copy Markdown
@tanstack/angular-store

npm i https://pkg.pr.new/@tanstack/angular-store@349

@tanstack/lit-store

npm i https://pkg.pr.new/@tanstack/lit-store@349

@tanstack/octane-store

npm i https://pkg.pr.new/@tanstack/octane-store@349

@tanstack/preact-store

npm i https://pkg.pr.new/@tanstack/preact-store@349

@tanstack/react-store

npm i https://pkg.pr.new/@tanstack/react-store@349

@tanstack/solid-store

npm i https://pkg.pr.new/@tanstack/solid-store@349

@tanstack/store

npm i https://pkg.pr.new/@tanstack/store@349

@tanstack/svelte-store

npm i https://pkg.pr.new/@tanstack/svelte-store@349

@tanstack/vue-store

npm i https://pkg.pr.new/@tanstack/vue-store@349

commit: caae78e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant