Skip to content

feat: open secrets if no other dynamic data is available#1861

Merged
maxy-shpfy merged 1 commit intomasterfrom
02-25-feat_open_secrets_if_no_other_dynamic_data_is_available
Feb 26, 2026
Merged

feat: open secrets if no other dynamic data is available#1861
maxy-shpfy merged 1 commit intomasterfrom
02-25-feat_open_secrets_if_no_other_dynamic_data_is_available

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 25, 2026

Description

Added a conditional rendering optimization for the DynamicDataDropdown component. When only secrets are available as dynamic data options, the component now renders a simplified lock button that directly opens the secret dialog instead of showing the full dropdown menu.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Screen Recording 2026-02-25 at 9.44.01 AM.mov (uploaded via Graphite)

Test Instructions

  1. Navigate to a task node's arguments editor where only secret dynamic data is available
  2. Verify that a lock icon button appears instead of the dropdown trigger
  3. Click the lock button and confirm it opens the secret dialog directly
  4. Test scenarios with mixed dynamic data types to ensure the dropdown still appears normally

Additional Comments

This change improves the user experience by providing a more direct interface when secrets are the only available dynamic data option, eliminating unnecessary dropdown navigation.

@maxy-shpfy maxy-shpfy mentioned this pull request Feb 25, 2026
4 tasks
Copy link
Collaborator Author

maxy-shpfy commented Feb 25, 2026

@maxy-shpfy maxy-shpfy marked this pull request as ready for review February 25, 2026 17:44
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner February 25, 2026 17:44
@maxy-shpfy maxy-shpfy force-pushed the 02-25-feat_open_secrets_if_no_other_dynamic_data_is_available branch from 86ffb25 to 326f156 Compare February 25, 2026 19:04
@maxy-shpfy maxy-shpfy force-pushed the 02-24-feat_display_dynamic_data_groups_only_for_curtain_tasks_with_annotations branch 2 times, most recently from 0e536b4 to d6c85b8 Compare February 26, 2026 04:33
@maxy-shpfy maxy-shpfy force-pushed the 02-25-feat_open_secrets_if_no_other_dynamic_data_is_available branch 2 times, most recently from d48b90b to 1b47626 Compare February 26, 2026 04:47
@maxy-shpfy maxy-shpfy force-pushed the 02-24-feat_display_dynamic_data_groups_only_for_curtain_tasks_with_annotations branch from d6c85b8 to c17e462 Compare February 26, 2026 04:47
Copy link
Collaborator Author

maxy-shpfy commented Feb 26, 2026

Merge activity

  • Feb 26, 5:02 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 26, 5:08 AM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 26, 5:12 AM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy changed the base branch from 02-24-feat_display_dynamic_data_groups_only_for_curtain_tasks_with_annotations to graphite-base/1861 February 26, 2026 05:05
@maxy-shpfy maxy-shpfy changed the base branch from graphite-base/1861 to master February 26, 2026 05:07
@maxy-shpfy maxy-shpfy force-pushed the 02-25-feat_open_secrets_if_no_other_dynamic_data_is_available branch from 1b47626 to 556173a Compare February 26, 2026 05:08
@maxy-shpfy maxy-shpfy merged commit 08099c0 into master Feb 26, 2026
14 checks passed
@maxy-shpfy maxy-shpfy deleted the 02-25-feat_open_secrets_if_no_other_dynamic_data_is_available branch February 26, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants