Repository navigation
Fix/test file pairing conventions - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Test files are now paired with their production file by trying the common naming
conventions, instead of removing the first four characters of the filename.
ExampleTest.java,ExampleTests.java,ExampleTestCase.javaandExampleIT.javanow pair correctly alongside the originaltestExample.java.An unmatched test file is skipped and reported rather than throwing a
NullPointerException that aborted the whole run — previously one oddly named file
meant a project of any size analyzed nothing.
Also fixes an operator precedence bug in test-file collection, where
&&boundtighter than
||so the duplicate check only applied to one branch.Also corrects documentation that attributed the pairing convention to the engine;
it is plugin code. Removes a stale limitation stating detection runs on the UI
thread, which was fixed in #73.
Testing
Eclipse 2026-09, on a project covering every supported convention plus one
deliberately unmatched file:
Result:
Analyzed 4 test file(s), with one dialog naming only OrphanTest.java.The run completed instead of aborting on the unmatched file.
Regression: SmellFixture still reports 20 smells.