Restore missing macro in NG45 ariane133.#3775
Open
sakundu wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
Restore missing macro in NG45 ariane133.#3775sakundu wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
sakundu wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Sayak Kundu <sakundu@ucsd.edu>
povik
approved these changes
Jan 9, 2026
Contributor
povik
left a comment
There was a problem hiding this comment.
This matches my earlier finding of why the macro gets pruned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed incorrect bit mapping in the limping_SyncSpRamBeNx64_00000008_00000100_0_2 module that was causing critical cache dirty/valid bits to be lost, resulting in a total of 132 macros, whereas 133 macros were expected.
Problem
The limping_SyncSpRamBeNx64_00000008_00000100_0_2 module (used by valid_dirty_sram) was storing bits [15:0] and zeroing bits [63:16]. However, the critical data (dirty_wdata[1:0], replicated for all eight cache ways) is located at bits [63:48], not [15:0].
As a result, the cache's valid/dirty status bits always read as zero, which could lead to the pruning of the valid_dirty_sram.
Fix
Changed the limping module to store bits [63:48] (the critical dirty/valid bits) instead of bits [15:0]:
// Before (incorrect):
fakeram45_256x16 macro_mem_0 (..., .rd_out(RdData_DO[15:0]), .wd_in(WrData_DI[15:0]));
assign RdData_DO[63:16] = 48'h0;
// After (fixed):
fakeram45_256x16 macro_mem_3 (..., .rd_out(RdData_DO[63:48]), .wd_in(WrData_DI[63:48]));
assign RdData_DO[47:0] = 48'h0;