Fix asap7 mbff lib files#3888
Merged
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom Feb 18, 2026
Merged
Conversation
Signed-off-by: LeeJaKang <wkrkd95@postech.ac.kr>
Signed-off-by: LeeJaKang <wkrkd95@postech.ac.kr>
edd9f14 to
2dfa2b6
Compare
Member
|
I have concerns about the correctness still. For example the one-bit DFFHQNx1_ASAP7_75t_R has a leakage of 1.50698e-10 (average of all conditional leakage() statements assuming equal likelihood). DFFHQNV2Xx1_ASAP7_75t_R is a two-bit MBFF with area that is exactly twice the above. The leakage however is 4.135266e-10 which is more than double the single-bit leakage above. I expect it to be at most equal and probably less to find some saving by clustering. |
Member
|
My bad I mixed up TT and FF corners. |
maliberty
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the ASAP7 [*_FAKE.lib] MBFF libraries with regenerated versions.
Why the previous lib values were incorrect
Our analysis of the existing FAKE MBFF libs found that some values deviated from the intended baseline.
The key issue was evidence that values were effectively copied from single-bit SDFH cells, instead of using the intended baseline single-bit flip-flop (i.e., DFFHQN).
As a result, leakage/power values were inconsistent with the intended corner/VT context, reducing MBFF data reliability.
Regeneration method
Instead of preserving legacy values, we regenerated the FAKE libs using the Python-script-based flow from the MBFFClustering repository.
Reference: https://github.com/ABKGroup/MBFFClustering
During regeneration, MBFF values were rebuilt using the corresponding SBFF with matched corner/VT, and existing FAKE files were replaced with the regenerated outputs.
Previously, the FAKE MBFF set was effectively TT-focused.
This update adds FF/SS coverage as well.
Now the following combinations are covered:
VT: LVT / RVT / SLVT
Corner: TT / FF / SS
DFHV-family FAKE libs were removed because they were considered unnecessary for this cleaned MBFF set.
Therefore, this PR keeps the FAKE MBFF set focused on the required MBFF cells only.