odb: add versions to make database versions consistent#9710
odb: add versions to make database versions consistent#9710gadfort wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Code Review
This pull request updates the database schema version and adds new constants to support parsing older database versions. My review focuses on improving the naming of the new constants for better consistency and clarity within the codebase. I've suggested renaming the new schema constants to include a DbGuide prefix, aligning them with existing naming conventions for dbGuide-related changes.
| inline constexpr uint32_t kSchemaIgnoreUsageRemoved = 128; | ||
|
|
||
| // Revision where the ignore_usage_ flag was added to dbGuide | ||
| inline constexpr uint32_t kSchemaIgnoreUsage = 127; |
There was a problem hiding this comment.
For consistency with other schema version constants related to dbGuide (e.g., kSchemaDbGuideCongested), it would be clearer to prefix these new constants with DbGuide. This improves readability and makes it easier to find all changes related to a specific database object.
| inline constexpr uint32_t kSchemaIgnoreUsageRemoved = 128; | |
| // Revision where the ignore_usage_ flag was added to dbGuide | |
| inline constexpr uint32_t kSchemaIgnoreUsage = 127; | |
| inline constexpr uint32_t kSchemaDbGuideIgnoreUsageRemoved = 128; | |
| // Revision where the ignore_usage_ flag was added to dbGuide | |
| inline constexpr uint32_t kSchemaDbGuideIgnoreUsage = 127; |
|
@eder-matheus FYI |
| inline constexpr uint32_t kSchemaIgnoreUsageRemoved = 128; | ||
|
|
||
| // Revision where the ignore_usage_ flag was added to dbGuide | ||
| inline constexpr uint32_t kSchemaIgnoreUsage = 127; |
There was a problem hiding this comment.
This kSchemaIgnoreUsage wasn't intended to be in master branch. I thought it was removed from my grt guides restore PR before the merge.
There was a problem hiding this comment.
@eder-matheus The issue here was that in your PR you dropped the DB version from 127 to 126. Once the version number if on master, it cannot be changed down otherwise it breaks any DBs created with it.
|
This is moot with: #9697 |
No-op but needed to allow version 127 databases to be parsed