Skip to content

builbo: some script clean-ups#23

Merged
obnoxxx merged 1 commit intoTheBuildBox:mainfrom
obnoxxx:builbo-some-cleanups
Mar 16, 2026
Merged

builbo: some script clean-ups#23
obnoxxx merged 1 commit intoTheBuildBox:mainfrom
obnoxxx:builbo-some-cleanups

Conversation

@obnoxxx
Copy link
Collaborator

@obnoxxx obnoxxx commented Mar 15, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 15, 2026 19:02
@obnoxxx obnoxxx force-pushed the builbo-some-cleanups branch from bcc309b to 6714d58 Compare March 15, 2026 19:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the builbo CLI script, primarily refactoring how defaults are defined/displayed and how command-line arguments/actions are parsed and validated.

Changes:

  • Introduces DEFAULT_* variables and updates usage() output to show those defaults.
  • Refactors argument parsing flow and adds extensive console logging during parsing.
  • Adjusts image naming/formatting and expands variable usage to ${...} form.
Comments suppressed due to low confidence (1)

cli/builbo:77

  • -i/--shell is documented in usage() (and mentioned in the help text), but it is not actually parsed/handled: optstring doesn’t include i, optstring_long doesn’t include shell, and there is no case arm for it. Either implement the option (set I_SHELL) or remove it from the usage/help text so the CLI contract matches behavior.
[ -s  | --build-script (command|path) ]              - command or local script (in the CWD)  for building the project.
[ -d | --deps (pkg,pkg,pkg,...) ]            - additional packages to install (comma-separated)
  -i | --shell (bash) ]                      - sinteractive shell (default: ${DEFAULT_I_SHELL})
[ -h | --help ]                              - action help: print this usage information
[-t | --test ]                               - action test: print some diagnostic info for  testing this program
[ -b | --build ]                             - action build: perform a build in the CWD
[ -e | --enter]                              - action enter: enter container in interactive mode (shell)


The Options -l, -r, -o, and -n in combination determine the  buildbox image (by tag) to be used.


The options -h, -t, -e, and -b are the available actions (help, test, enter, and build) to be performed.

Exactly one of the actions  must be selected.

The build action requires the additional option -s.
The enter action  makes use of the --shell option.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@obnoxxx obnoxxx force-pushed the builbo-some-cleanups branch 7 times, most recently from f7746ae to 774b6e4 Compare March 16, 2026 17:47
Signed-off-by: Michael Adam <obnox@samba.org>
@obnoxxx obnoxxx force-pushed the builbo-some-cleanups branch from 774b6e4 to 0c97fb5 Compare March 16, 2026 18:07
@obnoxxx obnoxxx enabled auto-merge (rebase) March 16, 2026 18:08
@obnoxxx obnoxxx merged commit 2b47d3b into TheBuildBox:main Mar 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants