Show / hide configuration associations (PP-4022)#213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an expandable disclosure panel to each row on the integration/configuration list pages, showing the libraries / roles associated with that service. Users can expand/collapse individual rows or use Expand all / Collapse all controls.
Alt+Clickon any toggle expands or collapses all rows at once.This is implemented as a set of overridable template methods on
GenericEditableConfigList:getAssociatedEntries— returns entries to display (orundefinedto suppress the toggle entirely)formatAssociatedCount— controls the count label (e.g. "3 libraries", "2 roles", "1 registered library")getAllLibraries— resolves short names to display names and edit linksEach component overrides as needed:
Also includes a few minor fixes picked up along the way:
UNSAFE_componentWillMountupdate tocomponentDidMount,(window as any).FormDataupdated toFormData,.catch()added tosave()to suppress unhandled-rejection warnings, andCollectionDatanow explicitly declaresmarked_for_deletion.Motivation and Context
Admins currently have no way to see which libraries are associated with a service without opening each service's edit form individually.
[Jira PP-4022]
How Has This Been Tested?
Checklist: