Fixes a PHP 8.4 Compatibility Issue

[Furex]

MysqliDb::insertMulti(): Implicitly marking parameter $dataKeys as nullable is deprecated, the explicit nullable type must be used instead in MysqliDb.php on line 850.

Fixes #1044

[avbdr]

Thank you for the patch. I assume that would break php4? (Not sure if somebody still needs php4...)

…

On Tue, Feb 18, 2025, 11:09 AM Sebastian Boo ***@***.***> wrote: MysqliDb::insertMulti(): Implicitly marking parameter $dataKeys as nullable is deprecated, the explicit nullable type must be used instead in MysqliDb.php on line 850. Fixes #1044 <#1044> ------------------------------ You can view, comment on, or merge this pull request online at: #1045 Commit Summary - c14716f <c14716f> Fixes a PHP 8.4 Compatibility Issue File Changes (1 file <https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/1045/files> ) - *M* MysqliDb.php <https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/1045/files#diff-ffa8f8b94ca4a1d6e37401846c71a534315221a6834cd36788a99058742d4699> (2) Patch Links: - https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/1045.patch - https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/1045.diff — Reply to this email directly, view it on GitHub <#1045>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZCL4SBO57MG2HMDPWDXET2QNEJZAVCNFSM6AAAAABXL4GZDGVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA3DANZTGYZTGMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Furex]

This will probably break everything below 7.1, thats when the nullable types was introduced

[pugelarouge]

If there are concerns about backwards compatibility would it not be wise to branch the project ? start v3 for say > 8.0 (or 7.4 or whatever) and keep a v2.9.x maintenance branch for whatever current minimum is up to 8.3 ??
seems a bit crazy to prevent compatibility (all be it deprecation warnings on start up) with current versions to maintain compatibility with version that are long since EOL ( and looks like this sort of issue will keep growing as php becomes tighter )

https://www.php.net/supported-versions

Thanks

[avbdr]

@ThingEngineer i think in 2026 there is no need to support php4 anymore?
lets make a NOTE, that for php4 they can use older release v2.X and lets release new as v3.0?
Agree?

[avbdr]

thats been fixed, thank you!

[Furex]

Why wasn’t there a merge, though?

[avbdr]

I'm sorry, I haveerged in different PR first